fix(web): clear changes views after deleting all sessions#14861
Closed
ravshansbox wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(web): clear changes views after deleting all sessions#14861ravshansbox wants to merge 1 commit intoanomalyco:devfrom
ravshansbox wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
4bd5b9a to
3f0956b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14860
Type of change
What does this PR do?
Problem: After deleting all sessions and navigating back to the session list (where
params.idisundefined), the following views still display stale content instead of being empty:Root Cause:
SessionReviewcomponent's local store is initialized with initial diffs and doesn't clear itself when diffs become emptytreestate (trackingactiveDiff,pendingDiff,reviewScroll) is only cleared whensessionKeychanges, but not whenparams.idbecomesundefinedChanges:
SessionReview component (
packages/ui/src/components/session-review.tsx):store.openstate whenprops.diffsbecomes emptySession page (
packages/app/src/pages/session.tsx):treestate (reviewScroll,pendingDiff,activeDiff) whenparams.idisundefinedHow did you verify your code works?
Verified that after deleting all sessions and navigating back to the session list:
Screenshots / recordings
N/A
Checklist