fix(acp): omit sessionId from loadSession response#14852
Closed
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(acp): omit sessionId from loadSession response#14852zerone0x wants to merge 1 commit intoanomalyco:devfrom
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Conversation
The ACP spec's LoadSessionResponse does not include a sessionId field, but loadSession() was returning the raw result from loadSessionMode() which includes sessionId. newSession() correctly constructs its own return object with sessionId; loadSession() should explicitly omit it. Fixes anomalyco#14746 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14746
Type of change
What does this PR do?
The ACP spec's
LoadSessionResponsedoes not include asessionIdfield. However,loadSession()was returning the raw object from the privateloadSessionMode()helper, which includessessionId. In contrast,newSession()correctly constructs its own return withsessionIdexplicitly included.Fixed by making
loadSession()return only the fields defined by the ACP spec (models,modes,_meta), droppingsessionId.How did you verify your code works?
Traced the call path manually:
loadSessionMode()returns{ sessionId, models, modes, _meta }newSession()destructures and adds its ownsessionIdloadSession()was returningresultdirectly; now returns{ models, modes, _meta }Screenshots / recordings
N/A — backend-only change.
Checklist