fix(app): connect font size setting to CSS variables and terminal#14821
Closed
praxstack wants to merge 2 commits intoanomalyco:devfrom
Closed
fix(app): connect font size setting to CSS variables and terminal#14821praxstack wants to merge 2 commits intoanomalyco:devfrom
praxstack wants to merge 2 commits intoanomalyco:devfrom
Conversation
- Add createEffect that applies fontSize to CSS custom properties (--font-size-base, --font-size-small, --font-size-large) - Replace hardcoded fontSize: 14 in terminal with settings value - Add font size stepper control (10-24px) in Settings > Appearance
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14823
Type of change
What does this PR do?
The
appearance.fontSizesetting existed in the data model (default: 14) but was disconnected — never applied to the DOM, terminal hardcoded 14, and no UI control existed.Three fixes:
createEffectthat applies fontSize to CSS custom properties (--font-size-base,--font-size-small,--font-size-large)fontSize: 14withsettings.appearance.fontSize()How did you verify your code works?
bun run --cwd packages/desktop tauri devScreenshots / recordings
Font size stepper appears in Settings > General > Appearance, below the font family picker.
Checklist