chore(story): fix window infinite scroll story#395
Closed
Balaji1202 wants to merge 1 commit intoankeetmaini:masterfrom
Closed
chore(story): fix window infinite scroll story#395Balaji1202 wants to merge 1 commit intoankeetmaini:masterfrom
Balaji1202 wants to merge 1 commit intoankeetmaini:masterfrom
Conversation
Fix to set proper data on refetching new data. The array of 100 elements are pushed as a single element. Spreading it out to push 100 individual elements.
Collaborator
|
Thanks, this was a real bug. The fix (adding the spread operator) has already been applied to the current codebase, so closing as superseded. Appreciate the catch. If you'd like to keep contributing, check out the open issues or file a new one if you find something worth fixing. Looking forward to more contributions from you, let's make this the best infinite scroll library out there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to set proper data on refetching new data. The array of 100 elements are pushed as a single element. Spreading it out to push 100 individual elements.