docs(aria/combobox): allow clear input with escape key#33282
Open
ok7sai wants to merge 1 commit into
Open
Conversation
angular-robot
Bot
added
area: docs
crisbeto
approved these changes
May 20, 2026
| [(value)]="searchString" | ||
| [(expanded)]="popupExpanded" | ||
| (click)="popupExpanded.set(true)" | ||
| (keydown.escape)="!popupExpanded() && !$event.defaultPrevented && searchString.set('')" |
Member
There was a problem hiding this comment.
Do we need the defaultPrevented check? I'm not sure we're preventing it anywhere.
Member
Author
There was a problem hiding this comment.
https://github.com/angular/components/blob/main/src/aria/private/combobox/combobox.ts#L140 the combobox handles the escape key and prevents default, without the defaultPrevented the input box will be cleared even when the popup is opened (the clear behavior should only happen when the popup is closed and escape hit is hit)... popupExpanded() returns false immediately once the escape key is hit, so we can't rely on that value.
Maybe the clear behavior needs to be baked into the combobox pattern... Let me take a further look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.