Conversation
aneojgurhem
reviewed
Nov 17, 2025
| * @see SessionHandle#delete() | ||
| * @see SessionState | ||
| */ | ||
| public CompletionStage<SessionState> deleteSession(SessionId sessionId) { |
Contributor
There was a problem hiding this comment.
why is the delete here ?
Collaborator
Author
There was a problem hiding this comment.
I have replaced it by closeSession()
5f74847 to
00f0373
Compare
aneojgurhem
previously approved these changes
Nov 18, 2025
00f0373 to
cc9e367
Compare
aneojgurhem
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
This PR introduces complete support for session retrieval and lifecycle management .
It expands the
SessionHandleAPI, enhances the underlying gRPC mapping layer,.This feature aligns the Java SDK with the full lifecycle exposed by the Sessions service (Create, Get, Pause, Resume, Cancel, Close, Purge, Delete).
Motivation
Sessions in ArmoniK are long-lived entities and can be reused across client restarts.
Until now, the Java SDK only supported:
openSession()But not:
SessionState)This PR completes the feature set and makes the Java SDK consistent with the official session lifecycle defined in ArmoniK.
Changes
✔️ Public API
New in
SessionHandleAll lifecycle operations are now available:
cancel()pause()resume()close()purge()delete()Each method:
CancelSession,PauseSession, etc.)CompletionStage<SessionState>SessionStaterecordArmoniKClientgetSession(SessionId)andgetSession(SessionId, BlobCompletionListener)deleteSession(SessionId)as a convenience APISessionStateFull Javadoc added.
✔️ Testing
Mapping tests
Added
SessionMapperTestto ensure correct mapping of:Wiring tests
Extended
SessionHandleTestto cover all lifecycle RPCs with minimal, high-value assertions:sessionIdpassedCompletionStagecompletes without exception(no redundant state assertions—mapping is already tested)
Backward compatibility
This PR is fully backward compatible:
openSession()and task submission untouched