Add Version.clean, stricter valid?, and || handling in satisfies?#12
Merged
Add Version.clean, stricter valid?, and || handling in satisfies?#12
Conversation
Version.clean validates and strips v prefix from version strings, returning nil for invalid input. Version.valid? now requires the x.y.z pattern instead of accepting bare numbers or non-version strings. Vers.satisfies? now splits on || to handle OR ranges directly rather than requiring callers to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to support removing VersionNormalization from downstream consumers:
Vers.clean(version)validates a version string matches x.y.z and strips the v prefix, returning nil for invalid inputVers.valid?now requires the x.y.z pattern instead of accepting bare numbers like "1" or non-version stringsVers.satisfies?now splits on||to handle OR ranges directly, so callers don't need to do it themselves