Conversation
ma7payne
force-pushed
the
HUDS-146
branch
2 times, most recently
from
89b3d6a to
5bf1280
Compare
MCele
approved these changes
Jun 19, 2025
negro89
reviewed
Aug 13, 2025
Contributor
negro89
left a comment
negro89
left a comment
There was a problem hiding this comment.
En lineas generales muy bien, pero sugiero un par de mejoras
modules/recetas/recetasController.ts
Outdated
Comment on lines
+13
to
+14
| const pacienteId = receta.paciente.id; | ||
| const recetaDisp = await getReceta(Types.ObjectId(receta.id), pacienteId, sistema); |
Contributor
There was a problem hiding this comment.
Por algun motivo este get falla bastante pasandole el id del paciente como bson. Dejo sugerencia que corrigió todas las ocurrencias:
Suggested change
| const pacienteId = receta.paciente.id; | |
| const recetaDisp = await getReceta(Types.ObjectId(receta.id), pacienteId, sistema); | |
| const pacienteId = receta.paciente.id.toString(); | |
| const recetaDisp = await getReceta(Types.ObjectId(receta.id), Types.ObjectId(pacienteId), sistema); |
jobs/actualizarEstadosDispensa.ts
Outdated
| dispensadas: 0, | ||
| sinDispensa: 0, | ||
| enUso: 0, // Recetas que están en uso y no se pueden actualizar | ||
| errores: 0 |
Contributor
There was a problem hiding this comment.
Agregaría un contador mas a modo de control: errorConsultandoEstado: 0 para en la linea 45 (cuando no se cumple resultado.success) sumar un else aumentando este contador:
Suggested change
| errores: 0 | |
| if (resultado.success) { | |
| . | |
| . | |
| . | |
| } else { | |
| resultados.errorConsultandoEstado++; | |
| } |
Contributor
Author
There was a problem hiding this comment.
Estan aplicados las sugerencias.
MCele
changed the title
negro89
approved these changes
Feb 25, 2026
liquid36
pushed a commit
that referenced
this pull request
Mar 4, 2026
# [5.141.0](v5.140.0...v5.141.0) (2026-03-04) ### Features * **HUDS:** implementa job para actualizar estados de dispensa ([#2056](#2056)) ([790e5a3](790e5a3))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/HUDS-146
Funcionalidad desarrollada
UserStories llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en otro repositorio