Update Dockerfile and docker-compose for k8s#30
Open
samimedallal wants to merge 8 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## tre #30 +/- ##
=======================================
Coverage 73.08% 73.08%
=======================================
Files 278 278
Lines 6026 6026
Branches 1661 1661
=======================================
Hits 4404 4404
Misses 1437 1437
Partials 185 185 Continue to review full report at Codecov.
|
joonvena
reviewed
Jan 17, 2022
joonvena
reviewed
Jan 17, 2022
joonvena
reviewed
Jan 17, 2022
joonvena
reviewed
Jan 20, 2022
| 'varaamo.vantaa.fi': 'VANTAA', | ||
| 'varaamotest-vantaa.hel.ninja': 'VANTAA', | ||
| 'varaamo.tampere.fi': 'TAMPERE', // PROD | ||
| 'localhost:3000': 'TAMPERE', // PROD |
There was a problem hiding this comment.
We don't want to change this. This would default to using Helsinki specific page for Varaamo.
joonvena
reviewed
Jan 20, 2022
| COPY . /app/ | ||
|
|
||
| COPY package.json package.json | ||
| RUN yarn install |
There was a problem hiding this comment.
Add this before the COPY . /app/ step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.