Tighten workflow-level permissions per audit#168
Merged
Conversation
Set top-level `permissions: {}` in release.yaml, validate-github-actions.yaml,
and validations.yaml. Push `contents: read` down to the job level in validations.yaml
where the checkout action requires it.
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets top-level
permissions: {}across the three workflow files that hadpermissions: contents: readat the workflow level. The contents permission is pushed down to the job level in validations.yaml where the checkout action needs it; release.yaml and validate-github-actions.yaml already had job-level permissions covering what each job needs.Changes: