drivers: adc: ad405x: fix GPIO leak in ad405x_init error paths#3063
Merged
drivers: adc: ad405x: fix GPIO leak in ad405x_init error paths#3063
Conversation
When ad405x_init_gpios() succeeds but the subsequent SPI/I3C init fails, error_dev only calls no_os_free() without removing the GPIOs. Similarly, error_com only removes the comm interface but not the GPIOs. Add an error_gpio label between them to properly release gpio_gpio0, gpio_gpio1 and gpio_cnv on failure. Fixes: 0f181cb ("drivers: ad405x: fix GPIO leak in error paths") Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
amiclaus
requested review from
CiprianRegus,
RaduSabau1,
buha,
cristina-suteu,
danmois,
dbogdan,
raezt,
ralucabozdog,
ranechita,
rbolboac,
rbudai98 and
stefpopa
as code owners
RaduSabau1
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ad405x_init_gpios() succeeds but the subsequent SPI/I3C init fails, error_dev only calls no_os_free() without removing the GPIOs. Similarly, error_com only removes the comm interface but not the GPIOs. Add an error_gpio label between them to properly release gpio_gpio0, gpio_gpio1 and gpio_cnv on failure.
Fixes: 0f181cb ("drivers: ad405x: fix GPIO leak in error paths")
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist