drivers: temperature: max31865pmb1: max31865: bugs fixes#3058
drivers: temperature: max31865pmb1: max31865: bugs fixes#3058nguyen-trong-tuan wants to merge 1 commit intoanalogdevicesinc:mainfrom
Conversation
need reassign value of reg_addr to field raw_array[] after check variable reg_addr with MAX31865_READ_MASK. Otherwise, checking mask is useless.
amiclaus
left a comment
There was a problem hiding this comment.
commit title prefix missing, 50/72 rule for commit is not followed, you are missing a fixes tag in the commit.
I updated commit title, if there are still missing rules, please give me the guideline for commit rules. |
amiclaus
left a comment
There was a problem hiding this comment.
you need to update the commit, not the PR with the above requests.
I don't understand how to do that, bro. I am not similar with your rule, do I need git pull, then create a new branch or fork? then just commit with message (-m), then git push? (Please give me the guide if any, tuannt99.hust@gmail.com, thank you very much) |
There was a problem hiding this comment.
you need to update the commit, not the PR with the above requests.
I don't understand how to do that, bro. I am not similar with your rule, do I need git pull, then create a new branch or fork? then just commit with message (-m), then git push? (Please give me the guide if any, tuannt99.hust@gmail.com, thank you very much)
git commit --amend -s
and then push force on the branch (your existing branch patch1)
drivers: temperature: max31865pmb1: max31865: fixes bug logic update value
Pull Request Description
drivers: temperature: max31865pmb1: max31865: fixes bug logic update value
PR Type
PR Checklist