Skip to content

drivers: temperature: max31865pmb1: max31865: bugs fixes#3058

Closed
nguyen-trong-tuan wants to merge 1 commit intoanalogdevicesinc:mainfrom
nguyen-trong-tuan:patch-1
Closed

drivers: temperature: max31865pmb1: max31865: bugs fixes#3058
nguyen-trong-tuan wants to merge 1 commit intoanalogdevicesinc:mainfrom
nguyen-trong-tuan:patch-1

Conversation

@nguyen-trong-tuan
Copy link
Copy Markdown

@nguyen-trong-tuan nguyen-trong-tuan commented Apr 7, 2026

drivers: temperature: max31865pmb1: max31865: fixes bug logic update value

Pull Request Description

drivers: temperature: max31865pmb1: max31865: fixes bug logic update value

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

need reassign value of reg_addr to field raw_array[] after check variable reg_addr with MAX31865_READ_MASK. Otherwise, checking mask is useless.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 7, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit title prefix missing, 50/72 rule for commit is not followed, you are missing a fixes tag in the commit.

@nguyen-trong-tuan nguyen-trong-tuan changed the title Fix max31865_read updating register value after correction in effect. drivers: temperature: max31865pmb1: max31865: bugs fixes Apr 8, 2026
@nguyen-trong-tuan
Copy link
Copy Markdown
Author

commit title prefix missing, 50/72 rule for commit is not followed, you are missing a fixes tag in the commit.

I updated commit title, if there are still missing rules, please give me the guideline for commit rules.

Copy link
Copy Markdown
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the commit, not the PR with the above requests.

@nguyen-trong-tuan
Copy link
Copy Markdown
Author

you need to update the commit, not the PR with the above requests.

I don't understand how to do that, bro. I am not similar with your rule, do I need git pull, then create a new branch or fork? then just commit with message (-m), then git push? (Please give me the guide if any, tuannt99.hust@gmail.com, thank you very much)

Copy link
Copy Markdown
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the commit, not the PR with the above requests.

I don't understand how to do that, bro. I am not similar with your rule, do I need git pull, then create a new branch or fork? then just commit with message (-m), then git push? (Please give me the guide if any, tuannt99.hust@gmail.com, thank you very much)

git commit --amend -s

and then push force on the branch (your existing branch patch1)

Copy link
Copy Markdown
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to inactivity on this thread i grabbed your patch and handled it with #3082

@amiclaus amiclaus closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants