Staging/adxl366 by marcocrio · Pull Request #3042 · analogdevicesinc/no-OS

marcocrio · 2026-03-31T16:47:28Z

Pull Request Description

Add ADXL366 ultra-low-power 3-axis accelerometer driver with complete Phase 1 feature set and hardware-validated evaluation project.

Driver Implementation (15 functions):

adxl366_init() - Device initialization
adxl366_remove() - Cleanup and removal
adxl366_reg_read() - Single register read
adxl366_reg_write() - Single register write
adxl366_reg_read_multiple() - Multi-byte register read
adxl366_set_range() - Set measurement range (±2g/±4g/±8g)
adxl366_get_range() - Get measurement range
adxl366_set_odr() - Set output data rate (12.5Hz-400Hz)
adxl366_get_odr() - Get output data rate
adxl366_set_power_mode() - Set power mode (standby/measure)
adxl366_get_power_mode() - Get power mode
adxl366_read_accel() - Read 14-bit X/Y/Z acceleration data
adxl366_read_temperature() - Read temperature sensor
adxl366_get_status() - Read status register
adxl366_software_reset() - Software reset

Evaluation Project (MAX32655 FTHR):

Basic example: continuous accelerometer streaming
Comprehensive test: validates all 14 functions with explicit labeling
VSCode integration: build/flash tasks, IntelliSense paths configured
DEVELOPMENT.md: detailed strategy, technical decisions, upstream plan

Hardware Testing (March 30th, 2026):
ALL 14 FUNCTIONS TESTED AND PASSED on MAX32655 FTHR + ADXL366Z:
✅ Function 1: Device initialization
✅ Function 2: Register read (device ID verification)
✅ Functions 3-4: Range configuration (±2g, ±4g, ±8g)
✅ Functions 5-6: ODR configuration (12.5Hz, 50Hz, 100Hz, 400Hz)
✅ Functions 7-8: Temperature reading (25°C measured)
✅ Function 9: Accelerometer data (~1.4g magnitude measured)
✅ Function 10: Status register (DATA_RDY, AWAKE bits verified)
✅ Function 11: Register write operation
✅ Function 12: Multi-byte read operation
✅ Functions 13-14: Power mode control (standby/measure)

Project Structure:

Phase A (MAX32655): COMPLETE - ready for upstream contribution
Phase B (nRF54L15 with SDK): Next - after Phase A PR submitted
Phase C (Bare-metal nRF): Required - all phases must complete sequentially

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

Add ADXL366 ultra-low-power 3-axis accelerometer driver with complete Phase 1 feature set and hardware-validated evaluation project. Driver Implementation (15 functions): - adxl366_init() - Device initialization - adxl366_remove() - Cleanup and removal - adxl366_reg_read() - Single register read - adxl366_reg_write() - Single register write - adxl366_reg_read_multiple() - Multi-byte register read - adxl366_set_range() - Set measurement range (±2g/±4g/±8g) - adxl366_get_range() - Get measurement range - adxl366_set_odr() - Set output data rate (12.5Hz-400Hz) - adxl366_get_odr() - Get output data rate - adxl366_set_power_mode() - Set power mode (standby/measure) - adxl366_get_power_mode() - Get power mode - adxl366_read_accel() - Read 14-bit X/Y/Z acceleration data - adxl366_read_temperature() - Read temperature sensor - adxl366_get_status() - Read status register - adxl366_software_reset() - Software reset Evaluation Project (MAX32655 FTHR): - Basic example: continuous accelerometer streaming - Comprehensive test: validates all 14 functions with explicit labeling - VSCode integration: build/flash tasks, IntelliSense paths configured - DEVELOPMENT.md: detailed strategy, technical decisions, upstream plan Hardware Testing (March 30th, 2026): ALL 14 FUNCTIONS TESTED AND PASSED on MAX32655 FTHR + ADXL366Z: ✅ Function 1: Device initialization ✅ Function 2: Register read (device ID verification) ✅ Functions 3-4: Range configuration (±2g, ±4g, ±8g) ✅ Functions 5-6: ODR configuration (12.5Hz, 50Hz, 100Hz, 400Hz) ✅ Functions 7-8: Temperature reading (25°C measured) ✅ Function 9: Accelerometer data (~1.4g magnitude measured) ✅ Function 10: Status register (DATA_RDY, AWAKE bits verified) ✅ Function 11: Register write operation ✅ Function 12: Multi-byte read operation ✅ Functions 13-14: Power mode control (standby/measure) Project Structure: - Phase A (MAX32655): COMPLETE - ready for upstream contribution - Phase B (nRF54L15 with SDK): Next - after Phase A PR submitted - Phase C (Bare-metal nRF): Required - all phases must complete sequentially Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

Apply astyle formatting rules to pass CI checks: - Fix spacing and indentation in adxl366.c and adxl366.h - Fix formatting in comprehensive_example.c Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

Add README.rst documentation for ADXL366 driver including: - Device overview and applications - Driver initialization and configuration - Usage examples for SPI communication - Temperature and acceleration data reading Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

Add README.rst documentation for eval-adxl366z project including: - Project overview and hardware specifications - Basic and comprehensive test examples - MAX32655 platform connection details - Build and flash instructions - Hardware test results summary Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

Add Sphinx RST includes for ADXL366 driver and eval-adxl366z project to integrate with no-OS documentation build system. Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

CLAassistant · 2026-03-31T16:47:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

amiclaus

i started the review but looking through the datasheets it raises one big question. why is this driver not included in the adxl367? the functional diagrams look identical.

amiclaus · 2026-04-01T11:19:00Z

@@ -0,0 +1,6 @@
+{


this file should not be included.

amiclaus · 2026-04-01T11:19:34Z

+ * @brief Initialize the device.
+ */
+int adxl366_init(struct adxl366_dev **device,
+		 struct adxl366_init_param init_param)


this should be passed by pointer not value.

amiclaus · 2026-04-01T11:20:16Z

+		return -EINVAL;
+
+	/* Read 6 bytes starting from XDATA_H */
+	ret = adxl366_reg_read_multiple(dev, ADXL366_REG_XDATA_H, buf, 6);


don't you need to check data_rdy bit?

amiclaus · 2026-04-01T11:22:01Z

+		return ret;
+
+	/* Combine high and low bytes (14-bit data in upper 14 bits) */
+	*x = ((int16_t)buf[0] << 8) | buf[1];


consider using the approach in adxl367:

if (*x & NO_OS_BIT(13)) *x |= NO_OS_GENMASK(15, 14);

marcocrio · 2026-04-02T20:35:40Z

i started the review but looking through the datasheets it raises one big question. why is this driver not included in the adxl367? the functional diagrams look identical.

I guess you're right, examining the ADXL367 driver closely, it seems to be a 100% compatible with the ADXL336. I may close the PR unless for organizing purposes an ADXL366 driver may want to be added

amiclaus

i started the review but looking through the datasheets it raises one big question. why is this driver not included in the adxl367? the functional diagrams look identical.

I guess you're right, examining the ADXL367 driver closely, it seems to be a 100% compatible with the ADXL336. I may close the PR unless for organizing purposes an ADXL366 driver may want to be added

you can have a look at other drivers that support multiple parts (currently usually through an enum device_type or similar).

buha · 2026-04-20T12:27:27Z

please reopen when you continue the development

marcoramirezcastro added 5 commits March 31, 2026 11:39

drivers: accel: adxl366: Fix astyle formatting

7ceb2dd

Apply astyle formatting rules to pass CI checks: - Fix spacing and indentation in adxl366.c and adxl366.h - Fix formatting in comprehensive_example.c Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

docs: adxl366: Add Sphinx documentation

ef6812a

Add Sphinx RST includes for ADXL366 driver and eval-adxl366z project to integrate with no-OS documentation build system. Signed-off-by: Marco A Ramirez Castro <marco.ramirezcastro@analog.com>

marcocrio requested review from CiprianRegus, RaduSabau1, amiclaus, buha, cristina-suteu, danmois, dbogdan, raezt, ralucabozdog, ranechita, rbolboac, rbudai98 and stefpopa as code owners March 31, 2026 16:47

github-actions Bot added drivers projects documentation labels Mar 31, 2026

amiclaus reviewed Apr 1, 2026

View reviewed changes

amiclaus reviewed Apr 3, 2026

View reviewed changes

buha closed this Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Staging/adxl366#3042

Staging/adxl366#3042
marcocrio wants to merge 5 commits intoanalogdevicesinc:mainfrom
marcocrio:staging/adxl366

marcocrio commented Mar 31, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Mar 31, 2026

Uh oh!

amiclaus left a comment

Uh oh!

amiclaus Apr 1, 2026

Uh oh!

amiclaus Apr 1, 2026

Uh oh!

amiclaus Apr 1, 2026

Uh oh!

amiclaus Apr 1, 2026

Uh oh!

marcocrio commented Apr 2, 2026

Uh oh!

amiclaus left a comment •

edited

Loading

Uh oh!

buha commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

marcocrio commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

PR Type

PR Checklist

Uh oh!

CLAassistant commented Mar 31, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

amiclaus Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

amiclaus Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

amiclaus Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

amiclaus Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

marcocrio commented Apr 2, 2026

Uh oh!

amiclaus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

buha commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcocrio commented Mar 31, 2026 •

edited

Loading

amiclaus left a comment •

edited

Loading