Staging/eval cn0391 ardz by MirceaVlasin · Pull Request #2989 · analogdevicesinc/no-OS

MirceaVlasin · 2026-03-11T06:43:50Z

Pull Request Description

Create a project for TypeK thermocouple (TC) data acquisition (Embedded World 2026 demo scope), based on EVAL-ADIN1110EBZ and EVAL-CN0391-ARDZ boards.

Add CN0391 board support driver (cn0391.c/h) with full temperature measurement: thermocouple voltage, CJC RTD resistance, cold junction compensation and hot junction temperature across 4 channels (CH0–CH3).

Add a maximal CN0391 IIO device(iio_cn0391.c/h) exposing 4 full TC temperature channels with hot_junction_temp, cold_junction_temp, tc_voltage and rtd_resistance attributes; the full CN0391 IIO device is optional via CN0391_IIO_SUPPORT=y.

Add a custom AD7124-8 IIO device extension which is used by default, presenting each TC channel as a voltage channel with raw (hot junction temperature in °C) and scale attributes matching the requirements related to integration with current SCOPY implementation.

Add two examples: basic (UART temperature readout) and iio_lwip (Ethernet IIO server via ADIN1110 10BASE-T1L, static IP configurable at build time).

Use single conversion mode for AD7124-8 acquisition, enabling only the 3 required ADC channels (TC/R_REF/RTD) per TC read.

Add minimal project documentation that could be subject of updating (eg. after CN0391 IIO device/plugin will be natively supported by SCOPY).

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant · 2026-03-11T06:43:58Z

All committers have signed the CLA.

amiclaus

doc build issue seems valid. complaining about the new drivers not having a documentation.

amiclaus · 2026-03-11T10:59:42Z

+#include <math.h>
+#include "no_os_rtd.h"
+
+double no_os_pt1000_resistance_to_temp(double resistance)


maybe this driver and the thermocouple one belong to util?

amiclaus · 2026-03-12T09:13:03Z

 	sdma_ch->hdma->Init.Channel = sdma_ch->ch_num;
 #else
-	sdma_ch->hdma->Instance = sdma_ch->ch_num;
+	sdma_ch->hdma->Instance = (DMA_Channel_TypeDef *)sdma_ch->ch_num;


the changes in stm32_dma should be in separate commit.

amiclaus · 2026-03-12T09:13:29Z

+ * Copyright 2026(c) Analog Devices, Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:


both no_os_rtd and no_os_thermocouple should have thier own commit.

amiclaus · 2026-03-12T09:14:31Z

+ * @param priv    - Unused.
+ * @return Number of bytes written, or negative error code.
+ */
+static int cn0391_iio_read_raw_tc(void *device, char *buf, uint32_t len,


this commit should be squashed with the projects commit.

amiclaus · 2026-03-12T09:15:37Z

-/**
- * @brief Callendar-Van Dusen equation for Pt1000 RTD (IEC 60751).
- *        Converts RTD resistance to temperature. For T < 0°C a Newton-Raphson
- *        refinement loop is applied to account for the cubic C term.


we don't create patchfixes for stuff added in the same PR.

amiclaus

some comments from my side above, prior to in-depth review.

MirceaVlasin · 2026-03-30T12:02:16Z

v2:

commits has been reorganized according to above PR's comments;
some previous iterative changes was lost, now we have the final implementation;
no HW available to perform a real test

amiclaus

some comments on my side.

amiclaus · 2026-03-30T12:32:28Z

 */
 int stm32_dma_init(struct no_os_dma_desc** desc,
-		   const struct no_os_dma_init_param* param)
+		   struct no_os_dma_init_param* param)


hmm, why not adding const to the ops signature? the const is correct here we don't want to modify param in the function.

I agree the "init_params" should be const(the same on CAPI, as a general rule), but in order to remove the compiling error that will be generated beginnig with GCC 14(warnings migrated to errors related to const -> non-const conversion, with the migration to CubeIDE 2.1.0), I've changed the routine definition in this manner bacause:

There is no general rule on No-OS's drivers initialization routines to receive a const init structure(eg. no_os_uart_init, no_os_flash_init, ...).

The other solution(to change init function signature on no_os_dma.h and no_os_dma.c) should affect also the other platforms. and more changes should need.

amiclaus · 2026-03-30T12:36:07Z

+				  const struct iio_ch_info *channel,
+				  intptr_t priv)
+{
+	struct cn0391_dev *dev = (struct cn0391_dev *)device;


why are these functions outside CN0391_IIO_SUPPORT ?

These functions exposes the custom AD7124-8 IIO device extension which is used by default, presenting each TC channel as a voltage channel with raw (hot junction temperature in °C) and scale attributes matching the requirements related to integration with current SCOPY implementation for Embedded World Demo.
The IIO device guarded by CN0391_IIO_SUPPORT, will be normally the standard/real IIO profile for CN0391, as soon as the SCOPY will provide a specific plugin for it.

amiclaus · 2026-03-30T12:37:02Z

+ * @param priv    - One of cn0391_iio_attr_id.
+ * @return Number of bytes written, or negative error code.
+ */
+static int cn0391_iio_read_processed(void *device, char *buf, uint32_t len,


hmm, this function looks similar to cn0391_iio_read_processed. can we have only one implementation?

You are refering to cn0391_iio_read_raw_tc?

Throug cn0391_iio_read_processed, the IIO client will be able to access any related parameter from the context of TC channel measurement(more parameters versus cn0391_iio_read_raw_tc, covering the custom IIO device with a single parameter). I should keep it for singular split functionality related to CN0391_IIO_SUPPORT.
The IIO device guarded by CN0391_IIO_SUPPORT, will be normally the standard/real IIO profile for CN0391, as soon as the SCOPY will provide a specific plugin for it.

amiclaus · 2026-03-30T12:37:48Z

+		no_os_mdelay(2000);
+	}
+
+	cn0391_remove(dev);


this is dead code.

Agree. I'll remove it or I'll integrate it on an exit condition(eg. if more than X consecutive failed reads).

amiclaus · 2026-03-30T12:38:36Z

+#endif
+	};
+
+	memcpy(adin1110_ip.mac_address, adin1110_mac_address, NETIF_MAX_HWADDR_LEN);


this requires string.h

Agree. There was no warning because it is included,I suppose, in one of the lwip headers.

amiclaus · 2026-03-31T08:31:21Z

+	*rtd_resistance = r_rtd;
+
+	return 0;
+}


nit: new line at EOF missing, detected by github.

amiclaus · 2026-03-31T08:32:03Z

 */
 int stm32_dma_init(struct no_os_dma_desc** desc,
-		   const struct no_os_dma_init_param* param)
+		   struct no_os_dma_init_param* param)


Fix some compiling errors related to GCC 14 toolchain, part of the last CubeIDE 2.1.0. The changes have impact only on STM32 platform and should't affect the other platforms. Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

Add utility modules, to cover conversion for PT1000 RTD and TypeK thermocouple, following the no-OS util convention for platform-agnostic utilities. Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

Add CN0391 board support driver (cn0391.c/h) with full temperature measurement: thermocouple voltage, CJC RTD resistance, cold junction compensation and hot junction temperature across 4 channels (CH0–CH3). Add a maximal CN0391 IIO device(iio_cn0391.c/h) exposing 4 full TC temperature channels with hot_junction_temp, cold_junction_temp, tc_voltage and rtd_resistance attributes. The full CN0391 IIO device is optional via CN0391_IIO_SUPPORT=y. Add a custom AD7124-8 IIO device extension which is used by default, presenting each TC channel as a voltage channel with raw (hot junction temperature in °C) and scale attributes matching the requirements related to integration with current SCOPY implementation. Use single conversion mode for AD7124-8 acquisition, enabling only the 3 required ADC channels (TC/R_REF/RTD) per TC read. Add two build examples: -basic: continuous UART print of CH3 measurements at 2s interval. -iio_lwip: Ethernet IIO server via ADIN1110. Static IP is configurable at build time with ADIN1110_STATIC_IP (default: 192.168.97.60/255.255.0.0). Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

Add minimal project documentation that could be subject of updating (eg. after CN0391 IIO device/plugin will be natively supported by SCOPY). Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

MirceaVlasin · 2026-04-20T14:49:01Z

v3:

addressing of PR's comments
retested with real CN0391 board

amiclaus

one inline comment
937028b should be dropped and the review adjustments should be in their afferent commits.
nit: I'd go for the @analog.com signature

amiclaus · 2026-04-20T15:25:35Z

+#include "no_os_rtd.h"
+
+#define CN0391_ADC_RESOLUTION		24
+#define CN0391_ADC_HALF_RESOLUTION	(1 << (CN0391_ADC_RESOLUTION - 1))


this is misleading for 2 reasons:

#define CN0391_ADC_HALF_RESOLUTION (1 << (CN0391_ADC_RESOLUTION - 1)). are we using only the bipolar mode? or why are we using half resolution?

#define CN0391_ADC_RESOLUTION 24 should be 1 << 24 ?

MirceaVlasin requested review from CiprianRegus, RaduSabau1, amiclaus, buha, cristina-suteu, danmois, dbogdan, raezt, ralucabozdog, ranechita, rbolboac, rbudai98 and stefpopa as code owners March 11, 2026 06:43

github-actions Bot added drivers projects documentation labels Mar 11, 2026

amiclaus reviewed Mar 11, 2026

View reviewed changes

amiclaus reviewed Mar 12, 2026

View reviewed changes

MirceaVlasin force-pushed the staging/eval-cn0391-ardz branch from 2c04de4 to 70baf5d Compare March 30, 2026 11:52

amiclaus reviewed Mar 30, 2026

View reviewed changes

amiclaus reviewed Mar 31, 2026

View reviewed changes

MirceaVlasin added 5 commits April 20, 2026 13:35

drivers: stm32: fix compiling errors

d7e5fab

Fix some compiling errors related to GCC 14 toolchain, part of the last CubeIDE 2.1.0. The changes have impact only on STM32 platform and should't affect the other platforms. Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

util: temperature: add conversion utilities

2cb8b92

Add utility modules, to cover conversion for PT1000 RTD and TypeK thermocouple, following the no-OS util convention for platform-agnostic utilities. Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

docs: cn0391: Add README documentation

d1e0ae3

Add minimal project documentation that could be subject of updating (eg. after CN0391 IIO device/plugin will be natively supported by SCOPY). Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

project: cn0391: Addressing PR's comments

937028b

Signed-off-by: MirceaVlasin <mirceavlasin@yahoo.com>

MirceaVlasin force-pushed the staging/eval-cn0391-ardz branch from 70baf5d to 937028b Compare April 20, 2026 14:42

amiclaus reviewed Apr 20, 2026

View reviewed changes

Conversation

MirceaVlasin commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

PR Type

PR Checklist

Uh oh!

CLAassistant commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amiclaus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

MirceaVlasin commented Mar 30, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MirceaVlasin Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MirceaVlasin commented Apr 20, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MirceaVlasin commented Mar 11, 2026 •

edited

Loading

CLAassistant commented Mar 11, 2026 •

edited

Loading

amiclaus left a comment •

edited

Loading

MirceaVlasin Mar 30, 2026 •

edited

Loading