ADMT4000 Calibration Kit Support by kister-jimenez · Pull Request #2856 · analogdevicesinc/no-OS

kister-jimenez · 2026-01-21T04:47:53Z

Pull Request Description

These changes provide support to the ADMT4000 Calibration Kit. The ADMT4000 Calibration Kit contains the ADMT4000 and a motor controller, which in this case is a TMC5240. This also support the variant without the motor controller.

The examples are as follows:
Basic Example - Contains simple firmware exercising some of the ADMT4000 driver APIs.
IIO Trigger Example - Exposes an IIOD. This one is a bit different as I included the use of the board EEPROM so that the firmware and the SDP-K1 can be discoverable in ACE/Eval Studio. The TMC5240 is also instantiated but can include/excluded via make arguments. There is also another IIO driver to expose the GPIOs used for the board that is not part of the chip. This is done so that the ADMT4000 IIO driver can be reused.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

buha · 2026-03-11T13:03:21Z

@kister-jimenez i think this is a well made PR, however, could you please check the CI output logs to fix those errors ?

run astyle on each commit
see what issues are there in docs and drivers build

Also, is the Draft label necessary ? I think you can remove it but maybe you have a reason for keeping it ?

kister-jimenez · 2026-03-11T13:16:06Z

@kister-jimenez i think this is a well made PR, however, could you please check the CI output logs to fix those errors ?

run astyle on each commit

see what issues are there in docs and drivers build

Also, is the Draft label necessary ? I think you can remove it but maybe you have a reason for keeping it ?

I was planning to complete first the TMC5240 PR before moving this to the active. I'm a bit not sure on the approach I did for the TMC library so I split the PR.

RaduSabau1 · 2026-03-30T15:24:20Z

Since the TMC related commits are already into main, I think you can reset them and rebase upon main.

kister-jimenez · 2026-04-08T16:46:50Z

V2:

Major refactor on the drivers, formula, formatting, APIs.
Added documentation for the driver and project.
removed the TMC5240 commits (merged in separate PR)
Added basic example

edelweiseescala

Hello sir kit, I just have some question about some flags for the board info library.

Also, some files do not have new line at the end.

edelweiseescala · 2026-04-10T00:15:25Z

+#define DEVICE_NAME			"EVAL-ADMT4000ARD1Z"
+#define DEVICE_VENDOR			"Analog Devices"
+#ifndef FW_VERSION
+#define FW_VERSION			"1.0.0"


Keeping FW_version might be confusing, FIRMWARE_VERSION is the one used by get_iio_context_attributes_ex

DEVICE_NAME and DEVICE_VENDOR information is from the eeprom, maybe should also be dropped.

I removed DEVICE_NAME and DEVICE_VENDOR. I kept the FIRMWARE_VERSION since this is not of part of the information in the EEPROM.

edelweiseescala · 2026-04-10T00:17:59Z

+INCS += $(PROJECT)/src/common/common_data.h
+
+# Add firmware version definition
+CFLAGS += -DFIRMWARE_VERSION=\"$(FIRMWARE_VERSION)\"


should we keep this here or move it to the src.mk

I removed this.

kister-jimenez · 2026-04-11T13:00:19Z

V3:

Fixed no newline at EoF.
Removed unused macro defines.
Addressed CI issues (remaining issues may not be related)

jcroleda · 2026-04-15T01:38:53Z

Hello sir Kit,

Just a couple minor suggestions:

jcroleda · 2026-04-15T01:39:13Z

+ *            writing registers, computing CRC, ECC encoding, and more.
+ *   @author Marc Sosa (marcpaolo.sosa@analog.com)
+ *   @author Jose Ramon San Buenaventura (jose.sanbuenaventura@analog.com)
+ *   @author Louijie Compo  (louijie.compo@analog.com)


Suggested change

* @author Louijie Compo (louijie.compo@analog.com)

* @author Louijie Compo (louijie.compo@analog.com)

* @author Kister Jimenez (kister.jimenez@analog.com)

ditto for other file headers

I did not write this driver and only did a little cleanup. I wanted to avoid having too many names in the driver.

jcroleda · 2026-04-15T01:43:35Z

+		temp = no_os_field_get(ADMT4000_LIFE_CTR | ADMT4000_FAULT_MASK,
+				       buf[3 + 4 * i]);
+
+		*angle_data = no_os_get_unaligned_be16(buf + 1 + 4 * i);


ditto

Suggested change

*angle_data = no_os_get_unaligned_be16(buf + 1 + 4 * i);

*angle_data = no_os_get_unaligned_be16(buf + 1 + ADMT4000_ANGLE_BUF_IDX(i));

kister-jimenez · 2026-04-17T01:49:18Z

V4:

Refactored crc computation. Converted to static inline including the ecc and hamming functions since only used internally.
addressed most magic numbers.
addressed unused variables, typos, and formatting issues.

jemfgeronimo

LGTM overall. Minor comments on formatting and small cleanups.

jemfgeronimo · 2026-04-20T02:41:24Z

+	ret = admt4000_toggle_cnv(device);
+	if (ret)
+		return ret;
+
+	return 0;


Suggested change

ret = admt4000_toggle_cnv(device);

if (ret)

return ret;

return 0;

return admt4000_toggle_cnv(device);

jemfgeronimo · 2026-04-20T02:45:32Z

+ */
+static int admt4000_compute_crc(uint32_t data_in, uint8_t *crc_ret)
+{
+


Unnecessary empty line.

jemfgeronimo · 2026-04-20T02:45:39Z

+
+		if (xor)
+			crc ^= 0x04;
+


Unnecessary empty line.

jemfgeronimo · 2026-04-20T02:47:06Z

+		return -EINVAL;
+
+	ret = admt4000_reg_read(device, reg_addr, &temp, NULL);
+


Unnecessary empty line.

jemfgeronimo · 2026-04-20T02:47:17Z

+	ret = admt4000_reg_update(device, ADMT4000_AGP_REG_CNVPAGE,
+				  ADMT4000_PAGE_MASK,
+				  no_os_field_prep(ADMT4000_PAGE_MASK, page));
+


Unnecessary empty line.

jemfgeronimo · 2026-04-20T02:47:53Z

+					ADMT4000_RISING_EDGE);
+		ret = admt4000_reg_update(device, ADMT4000_AGP_REG_CNVPAGE,
+					  ADMT4000_CNV_EDGE_MASK, temp);
+


You can remove empty line.

jemfgeronimo · 2026-04-20T02:47:57Z

+					ADMT4000_FALLING_EDGE);
+		ret = admt4000_reg_update(device, ADMT4000_AGP_REG_CNVPAGE,
+					  ADMT4000_CNV_EDGE_MASK, temp);
+


You can remove empty line.

jemfgeronimo · 2026-04-20T02:54:24Z

+				   13);
+
+	if (is_new_data)
+		*is_new_data = (bool)no_os_field_get(ADMT4000_NEW_DATA_MASK, raw_val);


Suggested change

*is_new_data = (bool)no_os_field_get(ADMT4000_NEW_DATA_MASK, raw_val);

*is_new_data = !!no_os_field_get(ADMT4000_NEW_DATA_MASK, raw_val);

Optional: My preference only, could use !! to normalize to boolean, but (bool) is also fine.

jemfgeronimo · 2026-04-20T02:59:12Z

+			       admt4000_conv_sync_mode_avail[i]);
+		if (ret < 0 || ret >= (int)(len - length))
+			return -ENOMEM;
+		length += ret;


Add empty line before this.

jemfgeronimo · 2026-04-20T03:00:07Z

+			       admt4000_harmonic_corr_src_avail[i]);
+		if (ret < 0 || ret >= (int)(len - length))
+			return -ENOMEM;
+		length += ret;


Add empty line before this.

edelweiseescala

I have no more question regarding how to read the eeprom. I just found this one issue on documentation

edelweiseescala · 2026-04-20T02:12:37Z

+ADMT4000 IIO Driver Initialization Example
+------------------------------------------
+
+.. code-block:: bash


I think this should be

Suggested change

.. code-block:: bash

.. code-block:: c

kister-jimenez · 2026-04-20T12:19:06Z

V5:

Minor formatting
fix minor typo in code block
remove register address limits on register read/write/update.

buha · 2026-04-20T12:32:55Z

@kister-jimenez please rebase and then we can perhaps merge

Add the Precision Converters Library as a git submodule. This library provides functions for reading EEPROM ID information from the boards. Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

Add project documentation for the ADMT4000 example project. Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

kister-jimenez · 2026-04-21T11:28:51Z

V6:

rebased to main.

kister-jimenez mentioned this pull request Jan 21, 2026

Dev/admt4000 #2462

Closed

10 tasks

kister-jimenez changed the title ~~Staging/admt4000~~ ADMT4000 Calibration Kit Support Jan 21, 2026

kister-jimenez force-pushed the staging/admt4000 branch from f464efb to c0503bd Compare February 2, 2026 04:28

github-actions Bot added drivers projects documentation CI labels Apr 8, 2026

kister-jimenez force-pushed the staging/admt4000 branch from e4e64a5 to 13a0712 Compare April 8, 2026 16:44

github-actions Bot removed the CI label Apr 8, 2026

kister-jimenez force-pushed the staging/admt4000 branch from 13a0712 to 2949f36 Compare April 8, 2026 18:23

kister-jimenez marked this pull request as ready for review April 8, 2026 18:30

kister-jimenez requested review from CiprianRegus, RaduSabau1, amiclaus, buha, cristina-suteu, danmois, dbogdan, raezt, ralucabozdog, ranechita, rbolboac, rbudai98 and stefpopa as code owners April 8, 2026 18:30

kister-jimenez force-pushed the staging/admt4000 branch 2 times, most recently from 2341f04 to 11796c5 Compare April 9, 2026 00:52

kister-jimenez force-pushed the staging/admt4000 branch from 11796c5 to 41260cc Compare April 9, 2026 01:19

edelweiseescala reviewed Apr 10, 2026

View reviewed changes

kister-jimenez force-pushed the staging/admt4000 branch 3 times, most recently from 2ceeae2 to e9877a3 Compare April 10, 2026 18:37

jcroleda reviewed Apr 15, 2026

View reviewed changes

jemfgeronimo reviewed Apr 15, 2026

View reviewed changes

kister-jimenez force-pushed the staging/admt4000 branch from e9877a3 to b56b9ae Compare April 16, 2026 12:45

github-advanced-security AI found potential problems Apr 16, 2026

View reviewed changes

Comment thread drivers/position/admt4000/iio_admt4000.c Fixed

Comment thread drivers/position/admt4000/iio_admt4000.c Fixed

kister-jimenez force-pushed the staging/admt4000 branch from b56b9ae to bcbf260 Compare April 16, 2026 13:31

jemfgeronimo reviewed Apr 20, 2026

View reviewed changes

edelweiseescala reviewed Apr 20, 2026

View reviewed changes

kister-jimenez force-pushed the staging/admt4000 branch 2 times, most recently from c47ff30 to 223c912 Compare April 20, 2026 12:18

kister-jimenez force-pushed the staging/admt4000 branch from 223c912 to 3d39875 Compare April 20, 2026 13:31

kister-jimenez added 6 commits April 21, 2026 19:27

libraries: Add precision-converters-library

130313e

Add the Precision Converters Library as a git submodule. This library provides functions for reading EEPROM ID information from the boards. Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

drivers: position: add driver for admt4000

5e99031

Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

drivers: position: admt4000: add iio support

4be16fa

Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

drivers: position: admt4000: add driver docs

22895cf

Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

projects: add examples for admt4000

12165bc

Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

docs: position: admt4000: Add project README

613e510

Add project documentation for the ADMT4000 example project. Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

kister-jimenez force-pushed the staging/admt4000 branch from 3d39875 to 613e510 Compare April 21, 2026 11:28

	* @author Louijie Compo (louijie.compo@analog.com)
	* @author Louijie Compo (louijie.compo@analog.com)
	* @author Kister Jimenez (kister.jimenez@analog.com)

	angle_data = no_os_get_unaligned_be16(buf + 1 + 4 i);
	*angle_data = no_os_get_unaligned_be16(buf + 1 + ADMT4000_ANGLE_BUF_IDX(i));

		return -EINVAL;

		ret = admt4000_reg_read(device, reg_addr, &temp, NULL);

	*is_new_data = (bool)no_os_field_get(ADMT4000_NEW_DATA_MASK, raw_val);
	*is_new_data = !!no_os_field_get(ADMT4000_NEW_DATA_MASK, raw_val);

Conversation

kister-jimenez commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

PR Type

PR Checklist

Uh oh!

buha commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kister-jimenez commented Mar 11, 2026

Uh oh!

RaduSabau1 commented Mar 30, 2026

Uh oh!

kister-jimenez commented Apr 8, 2026

Uh oh!

edelweiseescala left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kister-jimenez commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcroleda commented Apr 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kister-jimenez commented Apr 17, 2026

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

kister-jimenez commented Jan 21, 2026 •

edited

Loading

buha commented Mar 11, 2026 •

edited

Loading

kister-jimenez commented Apr 11, 2026 •

edited

Loading