migrate to QuickJS and prepare for 0.6.0 by amol- · Pull Request #85 · amol-/dukpy

amol- · 2026-02-06T23:44:54Z

No description provided.

webknjaz

I recommend separating ruff format into a dedicated commit/PR and then recording it in blame ignore — it's supported natively by GH: https://github.com/cherrypy/cheroot/blob/662cd9dcf426253536f921c618b480e65a429cb1/.git-blame-ignore-revs / https://github.com/ansible/awx-plugins/blob/274b32a7ab9eb09493b05e28eb5cad7441ec08bf/.git-blame-ignore-revs

webknjaz · 2026-02-08T07:46:34Z

pyproject.toml

@@ -0,0 +1,45 @@
+[build-system]
+requires = ["setuptools>=64", "wheel"]


Wheel was never needed here

Suggested change

requires = ["setuptools>=64", "wheel"]

requires = ["setuptools>=64"]

webknjaz · 2026-02-08T07:47:44Z

pyproject.toml

+  "Programming Language :: Python :: 3.9",
+  "Programming Language :: JavaScript",
+]
+dependencies = ["argparse; python_version == '2.6'"]


This is rather pointless given the classifiers

Suggested change

dependencies = ["argparse; python_version == '2.6'"]

webknjaz · 2026-02-08T07:49:45Z

pyproject.toml

+  "Programming Language :: Python :: 3.12",
+  "Programming Language :: Python :: 3.11",
+  "Programming Language :: Python :: 3.10",
+  "Programming Language :: Python :: 3.9",


Specify requires-python so that the depresolver takes it into account.

webknjaz · 2026-02-08T07:50:59Z

README.rst

+

 DukPy is a simple javascript interpreter for Python built on top of
-duktape engine **without any external dependency**.


It'd be nice to leave a historic reference explaining the project name.

webknjaz · 2026-02-08T07:54:11Z

scripts/update_quickjs_vendor.py

Consider integrating https://pypi.org/p/vendoring. It's Pradyun's thing used in pip.

webknjaz · 2026-02-08T07:55:42Z

.ruff.toml

@@ -0,0 +1,7 @@
+line-length = 88
+target-version = "py39"


Set requires-python in pyproject.toml instead.

Suggested change

target-version = "py39"

webknjaz · 2026-02-08T07:57:07Z

.ruff.toml

I recommend annotating whatever rules you list: https://github.com/cherrypy/cheroot/blob/662cd9dcf426253536f921c618b480e65a429cb1/.ruff.toml

webknjaz · 2026-02-08T08:00:19Z

.pre-commit-config.yaml

Use native integration, not local and you won't need to install ruff externally + run it in https://pre-commit.ci. Pro tip: with a double run, you can normalize trailing commas nicely — https://github.com/cherrypy/cheroot/blob/662cd9dcf426253536f921c618b480e65a429cb1/.pre-commit-config.yaml#L62-L87

webknjaz · 2026-02-08T08:00:45Z

.github/workflows/lint.yml

+      - uses: actions/checkout@v2
+      - name: Set up Python
+        uses: actions/setup-python@v2


These versions are quite outdated.

webknjaz · 2026-02-08T08:03:26Z

.github/workflows/lint.yml

+          pip install ruff pre-commit
+      - name: Ruff check
+        run: |
+          ruff check .
+          ruff format --check .


Don't install ruff, run pre-commit (although, you could also skip GHA and use the official app). Personally, I wrap linting things with tox: https://github.com/cherrypy/cheroot/blob/662cd9dcf426253536f921c618b480e65a429cb1/.github/workflows/ci-cd.yml#L606-L710

amol- · 2026-02-08T11:35:50Z

I recommend separating ruff format into a dedicated commit/PR and then recording it in blame ignore

Thanks for the review @webknjaz ! I really appreciate it.
Note that this branch is just a huge mess where I'm experimenting with the migration, some files I just copy/pasted them from other projects to have it up and runny quickly. I'm committing primarily just to be able to continue the work from the different PCs I use, but it's far from being in any stable or meaningful state. I'll get it out of Draft state when it's in a more serious state 😅

webknjaz · 2026-02-08T11:49:37Z

Yeah, I figured. Just wanted to post some feedback regarding easily fixable stuff.

amol- added 10 commits February 7, 2026 00:20

format, ruff, lint

3fd1476

start migration to quickjs

8358cee

Migrate toward pyproject.toml

3d40efe

Moving toward quickjs

94a10c9

Implement module loading

f35c703

Remove duktape

9b8961f

Remove compatibility code

85f8f27

Lint and format

8d87d8a

fix handling of null and undefined return values

66e8dd2

fix double free

5d19ac5

amol- force-pushed the 0.6.0 branch from a9b1e01 to 5d19ac5 Compare February 7, 2026 00:21

amol- added 6 commits February 7, 2026 00:22

Format script too

d25a0a0

enable/disable module mode on an explicit flag

28c4bb7

Improve exception reporting and map null and undefined to None

8421896

Add logo

82be5f8

Tweak pytest invocation, for windows

4240c62

Fix build on Windows

fcd2cf1

webknjaz reviewed Feb 8, 2026

View reviewed changes

		@@ -0,0 +1,45 @@
		[build-system]
		requires = ["setuptools>=64", "wheel"]

	requires = ["setuptools>=64", "wheel"]
	requires = ["setuptools>=64"]



		DukPy is a simple javascript interpreter for Python built on top of
		duktape engine without any external dependency.

Conversation

amol- commented Feb 6, 2026

Uh oh!

webknjaz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amol- commented Feb 8, 2026

Uh oh!

webknjaz commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants