Skip to content

Update rake requirement from ~> 10.0 to ~> 13.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update rake requirement from ~> 10.0 to ~> 13.0 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1476759
Edit CHANGELOG and bump version to v6.70.0 [skip assets]
Feb 24, 2021
493dd14
Update rake requirement from ~> 10.0 to ~> 13.0
dependabot[bot] Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ GEM
sawyer (~> 0.8.0, >= 0.5.3)
paint (2.1.0)
public_suffix (3.0.3)
rake (10.5.0)
rake (13.0.3)
rest-client (2.0.2)
http-cookie (>= 1.0.2, < 2.0)
mime-types (>= 1.16, < 4.0)
Expand All @@ -50,7 +50,7 @@ DEPENDENCIES
byebug
github_changelog_entry!
minitest (~> 5.0)
rake (~> 10.0)
rake (~> 13.0)

BUNDLED WITH
2.0.1
2 changes: 1 addition & 1 deletion github_changelog_entry.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_development_dependency "bundler", "~> 2.0"
spec.add_development_dependency "rake", "~> 10.0"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "minitest", "~> 5.0"
spec.add_development_dependency "byebug"
spec.add_dependency "octokit", "~> 4.0"
Expand Down
3 changes: 2 additions & 1 deletion lib/github_changelog_entry/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def filters
option :since, aliases: "-s", desc: %q{Date after which we want to search for issues}
option :milestone, aliases: "-m", desc: %q{Select issues linked to these milestones (ids)}
option :issue_state, default: "all", enum: ["open", "closed", "all"], desc: %q{Show only closed or open issues}
option :assignee, desc: %q{Filter github issues by assignee}
option :zenhub_opts, type: :hash, desc: %q{Defines zenhub options}, default: {}
option :output, aliases: "-o", desc: %q{Output type: changelog or csv}, default: "changelog"
def generate
Expand All @@ -67,7 +68,7 @@ def generate
github_handler = Github.new(options[:repo])
zenhub_fetcher = ZenhubIssueFetcher.new(@zenhub_token) if @zenhub_token

issues_options = options.select { |key, value| %w[since milestone issue_state].include?(key) }
issues_options = options.select { |key, value| %w[since milestone issue_state assignee].include?(key) }
issues = github_handler.issues(issues_options, zenhub_fetcher, filters)

if options[:output] == "changelog"
Expand Down
4 changes: 4 additions & 0 deletions lib/github_changelog_entry/github.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ def issues(options = {}, zenhub_fetcher, ext_filters)
filters.merge!(state: options["issue_state"])
end

if options["assignee"]
filters.merge!(assignee: options["assignee"])
end

issues = client.list_issues(@repo, filters).reject { |issue| issue.key?(:pull_request) }
github_issues_size = issues.size
Logger.instance.info("-> Retrieved #{github_issues_size} issues from github", [:blue])
Expand Down