Adds a test to demonstrate encoded path matching#149
Draft
sihugh wants to merge 1 commit into
Draft
Conversation
Contributor
|
Hmm interesting. Sounds like the current behaviour has potential for request smuggling shenaningans (but I've spent like 30 s thinking about it so not making any claims here!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy / tweak of existing tests and demonstrates that router routes things that are URL encoded.
At least one of our frontend apps is not built to handle URL encoded paths and errors under some circumstances. A sort of fix has been implemented for collections.
Should we "fix" router to not behave like this?
Related stack overflows are seem inconclusive - for example Apache allows you to toggle a setting to allow / disallow this.