WIP - test that graphql queries select all top level fields from thei…#3806
Draft
richardTowers wants to merge 8 commits intomainfrom
Draft
WIP - test that graphql queries select all top level fields from thei…#3806richardTowers wants to merge 8 commits intomainfrom
richardTowers wants to merge 8 commits intomainfrom
Conversation
richardTowers
commented
Jan 9, 2026
|
|
||
| RSpec.describe "GraphQL queries" do | ||
| Dir[Rails.root.join("app/graphql/queries/*.graphql")].each do |path| | ||
| /(?<schema_name>[^\/]+)[.]graphql\Z/ =~ path |
added 7 commits
January 10, 2026 13:02
I want to expose the internals of the GraphqlQueryBuilder so that I can use it in tests that check the generated queries haven't diverged from the logic that built them. It would probably be better to factor this functionality out into a separate helper that I could use in both the graphql query builder and the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r json schemas
... this is an idea of a way we could enforce that the GraphQL queries and the JSON schemas don't drift apart. It just checks the fields we select in the graphql query are all the same ones specified in the JSON schema (at the top level, and in details - not messing with links yet).