Python client: How to sanitise personalisation in send_email request#335
Python client: How to sanitise personalisation in send_email request#335CrystalPea wants to merge 2 commits into
Conversation
Following the pattern from rest API docs.
| # email will appear as: | ||
| Anne Example, now [click this evil link]() |
There was a problem hiding this comment.
This should be outside the code block (in a blockquote) because it’s not code
There was a problem hiding this comment.
we had it like that at the beginning, it looked harder to read. Looks like you have quite a few comments regarding content as such - this PR is just one of several PRs implementing the content that was previously reviewed (three of those have already been merged).
Feels like if we want to change the content, it would be good to do it in a separate PR in all docs where it's been implemented, so we maintain consistency?
There was a problem hiding this comment.
(although I already committed the more minor changes)
There was a problem hiding this comment.
Do you have a link to that discussion/draft?
There was a problem hiding this comment.
yeah the draft is here - not sure if google docs show discussion history: https://docs.google.com/document/d/1kehXL5m3LTJeqAmnlxW3C8Z-D2VBuI4QgvQD5oJ7pOM/edit?usp=sharing
To be fair the review happened back in the winter.
But yeah - for bigger changes, I'd say lets have a chat there, and if we decide to pursue them, lets implement in all docs at once?
And then this PR could be merged ahead of that discussion, so it could accompany the Python client changes.
The same will have to be done for restAPI, ruby and node docs. Co-authored-by: Chris Hill-Scott <me@quis.cc>
6e869ce to
be9924e
Compare
Following the pattern from rest API docs.
Here is a screenshot of how the guidance will look on the page: