Allow sanitise_content_for arg in send_email_notification endpoint#276
Open
CrystalPea wants to merge 1 commit intomainfrom
Open
Allow sanitise_content_for arg in send_email_notification endpoint#276CrystalPea wants to merge 1 commit intomainfrom
CrystalPea wants to merge 1 commit intomainfrom
Conversation
CrystalPea
force-pushed
the
allow_sanitise_content_for_placeholder_when_sending_email
branch
2 times, most recently
from
48652c5 to
60e00bb
Compare
So that users can tell us to sanitise content for specific placeholders. This is part of the work to mitigate against the placeholder injection vulnerability. Also add sanitised_content attribute to the response schema.
CrystalPea
force-pushed
the
allow_sanitise_content_for_placeholder_when_sending_email
branch
from
60e00bb to
3e9cdbe
Compare
CrystalPea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that users can tell us to sanitise content for specific placeholders. This is part of the work to mitigate against the placeholder injection vulnerability.
What problem does the pull request solve?
Checklist
CHANGELOG.mdnotifications_python_client/__init__.pynotifications-python-client/scripts/generate_docker_env.shnotifications-python-client/tox.iniCONTRIBUTING.md