Skip to content

client_live_key, client_test_key fixtures: provide client_id for correlation#656

Open
risicle wants to merge 1 commit into
mainfrom
ris-api-client-id
Open

client_live_key, client_test_key fixtures: provide client_id for correlation#656
risicle wants to merge 1 commit into
mainfrom
ris-api-client-id

Conversation

@risicle
Copy link
Copy Markdown
Member

@risicle risicle commented May 18, 2026

Functioning similarly to driver_id and included in User-agent, this should make it possible to correlate requests from a particular FT process with its corresponding logs server-side.

@risicle risicle force-pushed the ris-api-client-id branch from 9e105be to 67dd3d5 Compare May 18, 2026 13:57
…elation

functioning similarly to driver_id and included in User-agent, this
should make it possible to correlate requests from a particular
FT process with its corresponding logs server-side
@risicle risicle force-pushed the ris-api-client-id branch from 07dfcfa to 8926af3 Compare May 18, 2026 15:37
@risicle
Copy link
Copy Markdown
Member Author

risicle commented May 19, 2026

A slight complication because get_notification_by_to_field uses its own api client instance which doesn't immediately seem to fit well into a fixture. Instead it's going to get its own client (and therefore client id) per call. But in many of these cases the stack trace helpfully contains the headers dict that shows the User-agent, meaning not having display-on-teardown isn't a complete loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant