sqlalchemy: set connect_timeout to 4 seconds#4845
Merged
Merged
Conversation
we're currently seeing some unusual 5 second waits in api-web that aren't yielding the greenthread. if it's *this* 5s timeout that's responsible, changing it to 4s should cause us to start seeing 4s waits instead.
risicle
force-pushed
the
ris-sqlalchemy-connect-timeout-4
branch
from
1805e58 to
1b101b8
Compare
CrystalPea
reviewed
May 8, 2026
Contributor
CrystalPea
left a comment
CrystalPea
left a comment
There was a problem hiding this comment.
Are we changing the timeout as a performance improvement, or as a part of an investigation, or both?
Contributor
Just part of an investigation I think |
robinjam
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently seeing some unusual 5 second waits in api-web that aren't yielding the greenthread. If it's this 5s timeout that's responsible, changing it to 4s should cause us to start seeing 4s waits instead.