WIP: Make receipt_iso_timestamp mandatory in process_sms_client_response and process_ses_results#4843
Closed
robinjam wants to merge 2 commits into
Closed
WIP: Make receipt_iso_timestamp mandatory in process_sms_client_response and process_ses_results#4843robinjam wants to merge 2 commits into
receipt_iso_timestamp mandatory in process_sms_client_response and process_ses_results#4843robinjam wants to merge 2 commits into
Conversation
When adding attributes to an existing Celery task we have to make them optional, so that task invocations that were queued before the new attributes were introduced can still work. These attributes were all added a long time ago though, so that risk shouldn't exist anymore. This commit makes them all mandatory, and updates our tests accordingly. I've also made `receipt_iso_timestamp` non-nullable and removed the error handling around its parsing, because it's generated by us at the point where we receive the callback, and therefore can't ever be invalid (and if it ever is invalid then we have a bug).
When adding attributes to an existing Celery task we have to make them optional, so that task invocations that were queued before the new attributes were introduced can still work. The `receipt_iso_timestamp` attribute was added a long time ago though, so that risk shouldn't exist anymore. This commit makes it mandatory, and updates our tests accordingly. I've also made it non-nullable and removed the error handling around its parsing, because it's generated by us at the point where we receive the callback, and therefore can't ever be invalid (and if it ever is invalid then we have a bug).
robinjam
changed the title
receipt_iso_timestamp mandatory in process_sms_client_response and process_ses_resultsreceipt_iso_timestamp mandatory in process_sms_client_response and process_ses_results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/25A3gpXh/1358-replace-statsd-instrumentation-across-notify-with-otel
(Not strictly related to this ticket, but it's relevant because I want to use
receipt_iso_timestampin a metric)When adding attributes to an existing Celery task we have to make them optional, so that task invocations that were queued before the new attributes were introduced can still work.
These attributes were all added a long time ago though, so that risk shouldn't exist anymore. This commit makes them all mandatory, and updates our tests accordingly.
I've also made
receipt_iso_timestampnon-nullable and removed the error handling around its parsing, because it's generated by us at the point where we receive the callback, and therefore can't ever be invalid (and if it ever is invalid then we have a bug).