Send created_at date when creating letter for print#4842
Merged
Conversation
quis
force-pushed
the
show-created-date-on-letter
branch
from
6892456 to
d49644b
Compare
It’s better if the date on a templated letter is the date when the user
pressed _Send_ rather than when it was processed by us.
This is because:
- it will reflect what they see in the preview at the time of pressing
send
- it won’t change if we have to recreate the PDFs for any reason
In order to do this the API needs to tell template preview when the
letter was created.
***
Depends on:
- [ ] https://github.com/alphagov/notifications-template-preview/pull/973/files
quis
force-pushed
the
show-created-date-on-letter
branch
from
d49644b to
4f89100
Compare
CrystalPea
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It’s better if the date on a templated letter is the date when the user pressed Send rather than when it was processed by us.
This is because:
In order to do this the API needs to tell template preview when the letter was created.
Depends on:
datefield when creating letter for print notifications-template-preview#973