Skip to content

ssds#4833

Closed
WesleyHindle wants to merge 10 commits into
BC-sanitise-fixturesfrom
main
Closed

ssds#4833
WesleyHindle wants to merge 10 commits into
BC-sanitise-fixturesfrom
main

Conversation

@WesleyHindle
Copy link
Copy Markdown
Contributor

No description provided.

whpearson and others added 10 commits April 17, 2026 11:53
This turns on the feature

alphagov/notifications-utils#1336

By passing in environment variables.

We start checking for encrypted tokens before we encrypt them.

The plan is to keep the signing code around for at least a year,
so that we don't have eny tokens in things like unsubscribe links.

Encryption has been added everywhere for simplicities sake.
https://github.com/miguelgrinberg/Flask-Migrate/blob/main/CHANGES.md

Don’t see anything which should affect us. Breaking changes seem to be
dropping older versions of Python and Flask-SQLAlchemy
`api-worker-jobs-save` and `api-worker-jobs-save-documents` were listed
twice in the entrypoint. These removes the second places there were
listed, which are the ones that aren't used.
Make fixture creation resilient when running against a restored sanitised database, while keeping canonical fixture names stable (Functional Tests Org, Functional Tests, Performance Tests).

Key changes:
- Detect and rotate sanitised org/service rows that occupy canonical fixture names.
- Recreate canonical fixture org/service rows deterministically after rotation.
- Reclaim unique resources sanitised data may still own (domain, inbound number, inbound-linked SMS sender).
- Repair invalid API key secrets to prevent BadSignature failures in auth/serialisation paths.
- Keep fixture setup idempotent and safe to run repeatedly across environments.

Also updates fixture tests to cover sanitised-row rotation, resource reclaim behaviour, and API key repair logic.
Remove duplicated workers from entrypoint.sh
Upgrade Flask-Migrate to version 4
Pass encrypt key to check all the tokens
Add support for sanitised database restore inside the fixtures
Revert "Add support for sanitised database restore inside the fixtures"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants