feat: remove old archived email files from S3#4830
Conversation
5271170 to
1c9f19c
Compare
CrystalPea
left a comment
There was a problem hiding this comment.
Hi, good work on this, well done!
I left some comments. This is not the full review yet - Github seems to be playing up and losing some of my comments, so I want to submit to see what came through and avoid repeating myself. I will finish the review in a second swipe now.
|
I reviewed the rest of the PR and I have no more comments 🙌🏼 |
8648d63 to
46cdd68
Compare
46cdd68 to
553628a
Compare
|
@CrystalPea could you give a final look to the implementation of I did some refactoring, and I am now using older_than and .scalar() I noticed that the other keyset/cursor functions in our repo seems to use this pattern, so I tried to follow the same I also decided to use |
Summary
Added a daily task to remove archived template email files from S3. By default, it cleans a 1-day slice of files that are at least 14 days old. You can pass
archived_fromto backfill older files.Testing
Without argument
Running the task without archived_from uses the default cleanup window:
With argument
Providing archived_from widens/narrows the start of the window for backfill:
Ticket
Automatically remove stale email files from S3