Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/code-quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
poetry install --only ci

- name: Run code quality checks
run: make code-quality-check
run: |
make code-quality-check

- uses: actions/setup-node@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"editor.defaultFormatter": "esbenp.prettier-vscode",
"python.formatting.provider": "black",
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
}
}
21 changes: 7 additions & 14 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,26 +36,19 @@ test:
pytest

code-quality-fix:
# Python
poetry install --only ci
@echo "Fixing code quality issues with pre-commit..."
pre-commit run --all-files --hook-stage manual
# Complement with manual commands if necessary
poetry run ruff --fix . || true
poetry run black . || true

# TypeScript
cd client && npm ci
cd client && npm run lint -- --fix || true
cd client && npm run format || true

code-quality-check:
# Python
poetry install --only ci
poetry run ruff .
poetry run black --check .

# TypeScript
cd client && npm ci
cd client && npm run lint
cd client && npm run format -- --check
@echo "Running code quality checks with pre-commit..."
pre-commit run --all-files
# Complement with manual commands if necessary
poetry run mypy . || true

code-quality:
@echo "Running code-quality-fix and code-quality-check..."
Expand Down