fix: atomic writes for sync queue markers#34
Merged
davidpoblador merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
Concurrent blob uploads each trigger nudge_pending in separate threads. write_text truncates before writing, so a concurrent reader sees partial content and logs spurious "malformed marker" warnings. Use temp file + os.replace for all marker writes so readers always see complete content. Also logs the actual exception in malformed marker warnings for future debuggability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nudge_pendingin separate threads.write_texttruncates the file before writing, so a concurrent reader sees empty/partial content and logs spurious "Skipping malformed marker" warnings.os.replace(atomic on POSIX), so readers always see either old or new content, never partial.Test plan
test_corrupted_marker_file_skipped_gracefully— corrupted markers are skipped without affecting valid onestest_atomic_write_produces_valid_marker— markers remain valid JSON after writes and updates🤖 Generated with Claude Code