Skip to content

fix: deduplicate missing blobs and reduce sync error noise#28

Merged
davidpoblador merged 1 commit intomainfrom
worktree-graceful-jumping-allen
Apr 7, 2026
Merged

fix: deduplicate missing blobs and reduce sync error noise#28
davidpoblador merged 1 commit intomainfrom
worktree-graceful-jumping-allen

Conversation

@davidpoblador
Copy link
Copy Markdown
Member

@davidpoblador davidpoblador commented Apr 7, 2026

Summary

  • Deduplicate blob digests before the missing-blob check so the same digest isn't reported multiple times
  • Handle SyncMissingBlobsError as a warning (not error with full traceback) since missing blobs are an expected transient condition, not a bug
  • The warning message now explains what's happening and why: blobs aren't available locally yet and sync will retry once they arrive

Test plan

  • New test verifies duplicate blob digests are deduplicated in SyncMissingBlobsError.missing
  • New test verifies run_sync_loop logs missing blobs at WARNING level without a traceback
  • All 71 existing tests pass

🤖 Generated with Claude Code

@davidpoblador @claude
fix: deduplicate missing blobs and reduce sync error noise
24e3951 
Missing blob errors are an expected transient condition (blobs not yet
uploaded), not a bug. Log them as warnings without tracebacks so they
don't drown out real errors in the logs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@davidpoblador davidpoblador merged commit f53b9f0 into main Apr 7, 2026
@davidpoblador davidpoblador deleted the worktree-graceful-jumping-allen branch April 7, 2026 12:46
This was referenced Apr 7, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidpoblador