Conversation
2752c7e to
75c2b70
Compare
Collaborator
Code Review: PR #848 — feature - add more profile scopeAuthor: jianglan89 Summary为 RTP-LLM 添加更细粒度的 profiling 支持,主要变更:
评价改动方向正确,profiling scope 覆盖了调度器、stream 生命周期、缓存管理等关键路径。 P2 Suggestions1.
|
183c0f6 to
b41b927
Compare
- Remove unsafe const_cast on protobuf request in DecodeRpcServerNew.cc, set gen_timeline on generate_input after transQuery instead - Rename all_tp to enable_all_rank in StartProfileRequestPB - Add profile scopes to cache connector async read/write path - Fix missing ProfilingScope.h include in RemoteStoreTaskImpl.cpp - Fix RTP_LLM_PROFILE_SCOPE() empty param calls to RTP_LLM_PROFILE_FUNCTION() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b41b927 to
06787dd
Compare
LLLLKKKK
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.