feat: Support specifying BufferStrategy when open a database#162
feat: Support specifying BufferStrategy when open a database#162longbinlai merged 14 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Review Summary by QodoAdd memory level configuration support to database initialization
WalkthroughsDescription• Add memory_level parameter to Database initialization • Support three memory level options: InMemory, SyncToFile, HugePagePreferred • Enable flexible string aliases (camelCase, lowercase, snake_case) for memory levels • Add comprehensive test coverage for all memory level configurations Diagramflowchart LR
User["User specifies memory_level"] -->|Python API| PyDB["PyDatabase constructor"]
PyDB -->|Parse string| Parser["parse_memory_level function"]
Parser -->|Convert to enum| Config["NeugDBConfig.memory_level"]
Config -->|Pass to| Open["NeugDB::Open"]
Open -->|Log| Logging["VLOG with memory level info"]
File Changes1. tools/python_bind/neug/database.py
|
Code Review by Qodo
1. Enum std::to_string fails
|
|
这个pr 更改了 python接口,那么至少应该改下这个文档:https://github.com/alibaba/neug/tree/main/doc/source/reference/python_api. 另外,我看到这个配置是 "InMemory"且是默认的配置,那么这个配置和 没有指定 path时候的 in-memory 模式到底是什么关系?这个有点confuse |
2cdfddb to
32f971a
Compare
已经将参数名字更改为BufferStrategy. 默认改为M_HUGE |
… into expose-mem-level
User could specify the expected memory level to open the database:
Fix #174
Fix #180