fix(cosh): remove 24-item limit on @ file completion menu#92
Merged
kongche-jbw merged 1 commit intoalibaba:mainfrom Apr 7, 2026
Merged
fix(cosh): remove 24-item limit on @ file completion menu#92kongche-jbw merged 1 commit intoalibaba:mainfrom
kongche-jbw merged 1 commit intoalibaba:mainfrom
Conversation
- remove hardcoded maxResults cap in useAtCompletion that limited search results to 24 items
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the hardcoded
maxResultscap (MAX_SUGGESTIONS_TO_SHOW * 3 = 24) inuseAtCompletion.tsthat limited the@file selection menu to only 24 results. The UI layer already supports scrolling through unlimited results with 8-per-page pagination (▲/▼ indicators,(current/total)counter, wrap-around navigation).Related Issue
fixes #89
Type of Change
Scope
cosh(copilot-shell)agent-sec-coreos-skillsagentsightChecklist
cosh: Lint passes, type check passes, and tests passagent-sec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpassagent-sec-core(Python): Ruff format and pytest passos-skills: Skill directory structure is valid and shell scripts pass syntax checkpackage-lock.json/Cargo.lock)Testing
useAtCompletiontest suite (13 tests) all passnpm run buildsucceeds with no errorsmaxResultslets the backend (fileSearch.ts) return all matching results via its defaultInfinitybehaviorAdditional Notes
The root cause was in
useAtCompletion.ts:202wheremaxResults: MAX_SUGGESTIONS_TO_SHOW * 3capped search results at 24. Since the UI (useCompletion.ts+SuggestionsDisplay.tsx) already had full scroll/pagination support, simply removing this cap resolves the issue without any display-layer changes.