[feat] switch create_test_model to unified single-stage AOTI export#477
[feat] switch create_test_model to unified single-stage AOTI export#477tiankongdeguiji wants to merge 1 commit into
Conversation
Replace legacy two-stage AOT export (split_model + export_model_aot) with unified export_unified_model_aot in create_test_model, so unit tests exercise the same one-stage fused sparse+dense AOTI compilation path used in production. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ReviewThe change is minimal and correct: signatures align, A couple of points worth flagging: 1. Legacy two-stage AOT path becomes untested. 2. Test plan is missing one affected test. 3. CI compile-time. Compiling the full sparse+dense graph through Inductor is inherently heavier than dense-only AOTI; the PR description's ~190s for No security or doc concerns. |
Second-pass reviewRe-ran the analysis across code-quality, test-coverage, performance, docs, and security angles. The three substantive items from the prior top-level review still stand and I won't repeat them. One small new nit worth surfacing:
Wiring is otherwise clean — |
Summary
split_model+export_model_aot) with unified single-stageexport_unified_model_aotincreate_test_model, so unit tests exercise the same fused sparse+dense AOTI compilation path used in production.split_modelimport fromtest_util.py.Test plan
MultiTowerDINTest.test_multi_tower_din_3(AOT_INDUCTOR) — passed (18s, real AOTI compilation)DlrmHSTUTest.test_dlrm_hstu(Hypothesis with AOT_INDUCTOR examples) — passed (190s)🤖 Generated with Claude Code