Skip to content

feat(egress): add blocked hostname webhook fanout#406

Merged
hittyt merged 3 commits intoalibaba:mainfrom
Pangjiping:feat/egress-webhook
Mar 11, 2026
Merged

feat(egress): add blocked hostname webhook fanout#406
hittyt merged 3 commits intoalibaba:mainfrom
Pangjiping:feat/egress-webhook

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

Summary

  • add blocked hostname webhook fanout

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Pangjiping Pangjiping added the feature New feature or request label Mar 10, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@Pangjiping Pangjiping force-pushed the feat/egress-webhook branch 6 times, most recently from 0359dc7 to 0993c6e Compare March 11, 2026 01:56
@Pangjiping Pangjiping force-pushed the feat/egress-webhook branch from 0993c6e to edb7fe8 Compare March 11, 2026 10:02
@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Mar 11, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: edb7fe8808

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread components/egress/pkg/events/broadcaster.go Outdated
Comment thread components/egress/main.go Outdated
Copy link
Copy Markdown
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduces a valuable feature for monitoring blocked egress traffic via webhooks. However, there are a few high-priority concurrency and lifecycle issues that should be addressed to ensure stability during shutdown and avoid potential panics.

Comment thread components/egress/pkg/events/broadcaster.go
Comment thread components/egress/pkg/events/webhook.go
Comment thread components/egress/pkg/dnsproxy/proxy.go
@Pangjiping Pangjiping requested a review from hittyt March 11, 2026 10:29
Copy link
Copy Markdown
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 92dbdc8 into alibaba:main Mar 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/egress feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants