Skip to content

DRAFT: deferred index creation - no table version - do not merge #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michal-morzywolek wants to merge 68 commits into
base: main
Choose a base branch
from

Replace table-based deferred index tracking with replay-based discovery

77b4970
Select commit
Loading
Failed to load commit list.
Open

DRAFT: deferred index creation - no table version - do not merge #373

Replace table-based deferred index tracking with replay-based discovery
77b4970
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 20, 2026 in 2m 10s

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.6% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 270 in morf-core/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKtVmeaZoR4wBiJL&open=AZ0LpKtVmeaZoR4wBiJL&pullRequest=373

Check warning on line 27 in morf-integration-test/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexLifecycle.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.junit.Assert.fail'. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKnmmeaZoR4wBiJD&open=AZ0LpKnmmeaZoR4wBiJD&pullRequest=373

Check failure on line 242 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/SchemaChangeSequence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKpdmeaZoR4wBiJI&open=AZ0LpKpdmeaZoR4wBiJI&pullRequest=373

Check warning on line 286 in morf-integration-test/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexLifecycle.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testUpgrade_pendingIndexesForceBuiltBeforeProceeding" on line 188. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKnmmeaZoR4wBiJC&open=AZ0LpKnmmeaZoR4wBiJC&pullRequest=373

Check failure on line 186 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/deferred/DeferredIndexExecutorImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal ", index=" 5 times. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKn2meaZoR4wBiJE&open=AZ0LpKn2meaZoR4wBiJE&pullRequest=373

Check warning on line 19 in morf-core/src/test/java/org/alfasoftware/morf/upgrade/TestUpgradeGraph.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.hamcrest.Matchers.contains'. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKtwmeaZoR4wBiJM&open=AZ0LpKtwmeaZoR4wBiJM&pullRequest=373

Check warning on line 107 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/deferred/DeferredAddIndex.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this array creation and simply pass the elements. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKoGmeaZoR4wBiJF&open=AZ0LpKoGmeaZoR4wBiJF&pullRequest=373

Check warning on line 25 in morf-core/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexExecutorUnit.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.mockito.Mockito.never'. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKtGmeaZoR4wBiJK&open=AZ0LpKtGmeaZoR4wBiJK&pullRequest=373

Check failure on line 178 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/deferred/DeferredIndexTracker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "] -> [" 3 times. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKoYmeaZoR4wBiJG&open=AZ0LpKoYmeaZoR4wBiJG&pullRequest=373

Check warning on line 23 in morf-core/src/test/java/org/alfasoftware/morf/upgrade/TestSchemaChangeSequence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary import: same package classes are always implicitly imported. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKs2meaZoR4wBiJJ&open=AZ0LpKs2meaZoR4wBiJJ&pullRequest=373

Check warning on line 22 in morf-integration-test/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexReadinessCheck.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.junit.Assert.assertEquals'. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKljmeaZoR4wBiJA&open=AZ0LpKljmeaZoR4wBiJA&pullRequest=373

Check warning on line 32 in morf-integration-test/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexIntegration.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.Collection'. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKnTmeaZoR4wBiJB&open=AZ0LpKnTmeaZoR4wBiJB&pullRequest=373

Check warning on line 124 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/deferred/DeferredIndexReadinessCheckImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ0LpKommeaZoR4wBiJH&open=AZ0LpKommeaZoR4wBiJH&pullRequest=373
View more details on SonarQubeCloud