Skip to content

Treat no-operation upgrade nodes as non-exclusive #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ben-mcauley-alfa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Treat no-operation upgrade nodes as non-exclusive #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion morf-core/src/main/java/org/alfasoftware/morf/upgrade/GraphBasedUpgradeNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public List<String> getUpgradeStatements() {
* node should be executed while this one is being processed)
*/
public boolean requiresExclusiveExecution() {
return exclusiveExecution || reads.isEmpty() && modifies.isEmpty();
return exclusiveExecution || isRoot();
}


Expand Down
2 changes: 1 addition & 1 deletion morf-core/src/test/java/org/alfasoftware/morf/upgrade/TestGraphBasedUpgradeBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ public void testExclusiveNodeFirstThenStandard() {
public void testExclusiveNodeNotAParent() {
// given
when(upgradeTableResolution.getModifiedTables(U1000.class.getName())).thenReturn(Sets.newHashSet("t1"));
when(upgradeTableResolution.getModifiedTables(U1000.class.getName())).thenReturn(Sets.newHashSet("t1", "t2"));
when(upgradeTableResolution.getModifiedTables(U1001.class.getName())).thenReturn(Sets.newHashSet("t1", "t2"));
upgradeSteps.addAll(Lists.newArrayList(eu1, u1000, u1001));

// when
Expand Down