Add common traits for many (but not all) structs#11
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends several core structs with common trait derives, refactors the Point type to use OrderedFloat for total ordering, and adapts related code for those changes.
- Derive
Clone,Debug, andPartialEqonDistanceQuery,QuadTree, and other types. - Refactor
Pointto wrap its coordinates inOrderedFloat, addDisplay,Default, and manual (de)serialization support. - Update
Region::containsand other call sites to work with the newPoint::dimension_valuesAPI.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| quadtree/src/region.rs | Updated contains to pass a reference to values now returned by array. |
| quadtree/src/query.rs | Added #[derive(Clone, Debug)] to DistanceQuery. |
| quadtree/src/quadtree.rs | Added #[derive(Clone, PartialEq, Debug)] to QuadTree. |
| quadtree/src/point.rs | Switched from [f64; N] to [OrderedFloat<f64>; N], implemented Display, Default, and manual serdev (de)serialization, and adjusted APIs. |
| quadtree/Cargo.toml | Added dependencies on ordered-float, serdev, and test-only serde_json. |
Comments suppressed due to low confidence (1)
quadtree/src/region.rs:38
- The change to pass a reference here isn't covered by existing tests. Consider adding unit tests for
Region::containswith points inside and outside various intervals.
.all(|(interval, value)| interval.contains(&value))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.