Open
Conversation
added 2 commits
January 15, 2025 10:30
Owner
|
Thank you for your contribution to open-source! I plan to make these improvements available here so that anyone who needs them can use them freely. Since the modifications involve changes to the video aspect ratio, merging the branch would require retraining the model and reevaluating its performance, which might lead to discrepancies compared to the results presented in the paper. Therefore, merging the branch may not be feasible at the moment. However, the improvements will still be accessible here for those who need them. If you have a better solution, feel free to propose it! |
Owner
|
感謝你對於開源貢獻一份心力!這些改進我打算放在這裡讓有需要的人自行取用,因為有寫修改有動到影片比例,合併分支的話需要重新訓練模型與評估,可能會與論文展示的績效有差異,所以目前可能沒辦法合併分支,但是還是可以放在這裡讓有需要的人取用,如果有更好的解決方案也歡迎提出! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video was not scaling on x-axis correctly, small fix to be more robust to videos of different dimensions