Skip to content

PS-744 ci clean untagged images, bump action used version#771

Merged
nmaillat merged 3 commits intomasterfrom
PS-744_delete_untagged_image
Apr 13, 2026
Merged

PS-744 ci clean untagged images, bump action used version#771
nmaillat merged 3 commits intomasterfrom
PS-744_delete_untagged_image

Conversation

@nmaillat
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the branch-delete cleanup workflow to use a newer AWS credentials action and extends the workflow to remove untagged images from AWS ECR Public repositories (prefixed ps-).

Changes:

  • Bump aws-actions/configure-aws-credentials usage from v4 to v6 in the cleanup workflow.
  • Add a new workflow step to enumerate ps- ECR Public repos and batch-delete untagged images with a summary report.
Comments suppressed due to low confidence (1)

.github/workflows/cleanup-ecr-on-branch-delete.yaml:34

  • This workflow bumps aws-actions/configure-aws-credentials to @v6, but other workflows in this repo still use @v4 (e.g. .github/workflows/ci.yaml:338). Mixing major versions can introduce subtle behavior differences; consider standardizing on a single major version (and ideally pinning to a commit SHA if that’s the repo’s security policy).
        uses: aws-actions/configure-aws-credentials@v6
        with:
          aws-access-key-id: ${{ secrets.AWS_ECR_ACCESS_KEY_ID }}
          aws-secret-access-key: ${{ secrets.AWS_ECR_ACCESS_KEY_SECRET }}
          aws-region: us-east-1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/cleanup-ecr-on-branch-delete.yaml
Comment thread .github/workflows/cleanup-ecr-on-branch-delete.yaml Outdated
Comment thread .github/workflows/cleanup-ecr-on-branch-delete.yaml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/cleanup-ecr-on-branch-delete.yaml
Comment thread .github/workflows/cleanup-ecr-on-branch-delete.yaml Outdated
@nmaillat nmaillat requested a review from 4rthem April 13, 2026 06:55
echo " ⚠ $failed_count deletion(s) failed"
fi
else
echo " ✗ Error during batch delete"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if image exists to silently ignore this error. Otherwise we should exit with an error code.

@nmaillat nmaillat requested a review from 4rthem April 13, 2026 09:38
@nmaillat nmaillat merged commit 17e25b4 into master Apr 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants