PS-744 ci clean untagged images, bump action used version#771
Merged
PS-744 ci clean untagged images, bump action used version#771
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the branch-delete cleanup workflow to use a newer AWS credentials action and extends the workflow to remove untagged images from AWS ECR Public repositories (prefixed ps-).
Changes:
- Bump
aws-actions/configure-aws-credentialsusage fromv4tov6in the cleanup workflow. - Add a new workflow step to enumerate
ps-ECR Public repos and batch-delete untagged images with a summary report.
Comments suppressed due to low confidence (1)
.github/workflows/cleanup-ecr-on-branch-delete.yaml:34
- This workflow bumps
aws-actions/configure-aws-credentialsto@v6, but other workflows in this repo still use@v4(e.g..github/workflows/ci.yaml:338). Mixing major versions can introduce subtle behavior differences; consider standardizing on a single major version (and ideally pinning to a commit SHA if that’s the repo’s security policy).
uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.AWS_ECR_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_ECR_ACCESS_KEY_SECRET }}
aws-region: us-east-1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4rthem
requested changes
Apr 13, 2026
| echo " ⚠ $failed_count deletion(s) failed" | ||
| fi | ||
| else | ||
| echo " ✗ Error during batch delete" |
Member
There was a problem hiding this comment.
Check if image exists to silently ignore this error. Otherwise we should exit with an error code.
4rthem
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.