Mac: Added missing close, focus and resize events#33
Open
rthrfrd wants to merge 1 commit intoalaingalvan:masterfrom
Open
Mac: Added missing close, focus and resize events#33rthrfrd wants to merge 1 commit intoalaingalvan:masterfrom
rthrfrd wants to merge 1 commit intoalaingalvan:masterfrom
Conversation
Added an NSWindowDelegate to the NSWindow to get more information. Emits ApplicationDefined NSEvents back to the NSApplication to be picked up in the existing EventQueue.
Owner
|
Thanks Alex, this looks great, I'll go ahead and test it out on my end and merge it in after. 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the work to create this! Unfortunately it wouldn't fit my needs without some of these key events on Mac, so I've done my best to add them!
I added an
NSWindowDelegateto theNSWindowto get more information about what's happening with the window (looking at theNSWindowDelegateAPI, there's more that can now be done here I'm sure). It emitsNSEventsof type ApplicationDefined (as recommended by docs) back to theNSApplicationto be picked up in your existingEventQueue.I don't have much Objective-C experience so apologies in advance! I've tried to mirror the existing implementation/style as much as possible.