feat(serve): automatically reconnect client on server restart#1720
Merged
feat(serve): automatically reconnect client on server restart#1720
Conversation
xnv
approved these changes
Mar 30, 2026
dera-
reviewed
Mar 31, 2026
| // 切断済みの場合のみリロードする (初回接続時の serverReady は無視する)。 | ||
| // サーバが復帰したらページをリロードして再初期化する。 | ||
| // これにより同じサーバへの再接続でも新しいサーバへの接続でも正しく動作する。 | ||
| if (!this.store.isSocketDisconnect) return; |
Contributor
There was a problem hiding this comment.
ここで this.store.isSocketReconnecting のチェックもしなくて大丈夫でしょうか？
dera-
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
このPullRequestが解決する内容
サーバ切断時、サーバ側が再起動されたらクライアント側で自動的に再接続するように修正します。