fix: fix commands broken on early versions of Node.js v18, v20 and v21#1503
Merged
fix: fix commands broken on early versions of Node.js v18, v20 and v21#1503
Conversation
…1 by lacking file extensions
xnv
commented
Feb 13, 2025
| "scripts": { | ||
| "prepublish": "npm run build", | ||
| "start": "npm run build && node bin/run", | ||
| "start": "npm run build && node bin/akashic-cli-sandbox.js", |
Member
Author
There was a problem hiding this comment.
別件: 元々パスがおかしかったようなので修正。(sandbox で npm start することはなさそうなので、削除してしまっても良さそうですが)
xnv
commented
Feb 13, 2025
| "scripts": { | ||
| "prepublish": "npm run clean && npm run build", | ||
| "clean": "rimraf ./lib && rimraf ./spec/build", | ||
| "start": "npm run build && node bin/run", |
Member
Author
There was a problem hiding this comment.
別件2: 元々なかったファイルを指していました。extra 自体に start はありえないので削除。
yu-ogi
approved these changes
Feb 14, 2025
ShinobuTakahashi
approved these changes
Feb 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
掲題どおり。
ESM になっているモジュールにおいて、
bin/runのように拡張子のないファイルは、ある時期までの Node.js で (デフォルトでは) サポートされていない ようです 。具体的には v18.19.0 未満の v18 系や、v20.10.0 未満の v20 系が該当する とのこと 。EOL が近い v18 はまだしも v20 でトラブルになるのは避けたく、エラーメッセージのとおり拡張子を追加します。
package.json の bin 指定の問題なので、ユニットテストや test/e2e.js の --local では動作確認できません。Mac 上の Node 18.16.0 で sandbox, export などいくつか npm pack する限りでは問題ないので、prerelease で publish したもので動作確認します。