Conversation
xnv
commented
Aug 6, 2024
| urlWithQuery = `${url}?${queryString.stringify(params)}`; | ||
| } | ||
| const response = await fetchWithTimeout(urlWithQuery); | ||
| export const get = async<T>(url: string): Promise<T> => { |
Member
Author
There was a problem hiding this comment.
URLSearchParams で対応できるのですが、よく見ると利用箇所がなく、動作確認のしようもないので削除してしまいます。必要になった時に実装する想定です。del と ApiRequestMock の方も同様に削除。
ShinobuTakahashi
approved these changes
Aug 6, 2024
yu-ogi
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
掲題どおり。
#1320 のビルドエラーを解消するために query-string の依存を除き、
URLSearchParamsに移行します。変更後、Mac Chrome/Firefox/Safari 上で、akashic serve の?mode=replay&replayTargetTime=10000&paused=1オプションが機能することを確認しています。