Skip to content

Clean manifest and migrate MultiDex to AndroidX#6

Open
akarshan96 wants to merge 1 commit into
masterfrom
codex/update-androidmanifest-for-sdk-changes
Open

Clean manifest and migrate MultiDex to AndroidX#6
akarshan96 wants to merge 1 commit into
masterfrom
codex/update-androidmanifest-for-sdk-changes

Conversation

@akarshan96
Copy link
Copy Markdown
Owner

Summary

  • Remove <uses-sdk> and versionCode from manifest to rely on Gradle configuration
  • Switch to androidx.multidex.MultiDexApplication and update MultiDex dependency
  • Declare android:exported on all activities for API 31+

Testing

  • ./gradlew test (fails: Unable to tunnel through proxy. Proxy returns "HTTP/1.1 403 Forbidden")

https://chatgpt.com/codex/tasks/task_e_68b35e0077f08330a031cccef46940ad

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread app/build.gradle Outdated
Comment on lines +27 to +30
compile 'com.android.support:design:23.4.0'
compile 'com.github.bloder:magic:1.1'
compile 'com.google.android.gms:play-services:9.4.0'
compile 'com.android.support:multidex:1.0.0'
compile 'androidx.multidex:multidex:2.0.1'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Add Google Maven repository for AndroidX MultiDex

The new dependency androidx.multidex:multidex:2.0.1 will not resolve because this project’s Gradle configuration only declares jcenter() for both buildscript and allprojects repositories. AndroidX artifacts are served from the Google Maven repository, so Gradle 2.1.2 with jcenter alone will fail with Could not find androidx.multidex:multidex:2.0.1. Either add google() (or the explicit Maven URL) to the repositories or keep using the support library version to avoid breaking the build.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant