Make early-exit consider throwing as an early exit#141
Open
alcuadrado wants to merge 3 commits intoajafff:masterfrom
Open
Make early-exit consider throwing as an early exit#141alcuadrado wants to merge 3 commits intoajafff:masterfrom
alcuadrado wants to merge 3 commits intoajafff:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ajafff
Thanks for creating this package. I use multiple rules, which I find very useful.
I was considering enabling
early-exit, but was surprised by tslint complaining about this pattern:I can refactor that into this, but it feels like making things more complex instead of simpler:
So I modified this rule to consider throwing as an early exit.
I'm not 100% sure if what I did is correct, nor if the test I added actually works, but I preferred submitting this early to get your opinion about this change.