Some additional notes on naming conventions#165
Draft
unkillbob wants to merge 1 commit into
Draft
Conversation
… on abbreviations, acronyms, constants and class methods.
|
Note that constant naming is also discussed in #255 |
Collaborator
There was a problem hiding this comment.
JS doesn't really have "methods" - could this be functions instead?
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Collaborator
|
@unkillbob similarly, i'll need to be explicitly added to the orionhealth fork to be able to land this |
Contributor
Author
Collaborator
|
@unkillbob is there noone you can contact that could add me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of forking your amazing style guide and porting across some of the differences in our old internal style guide, we found some additional notes on naming conventions we thought might be worth sharing.
Includes recommendations on naming abbreviations, acronyms, constants and class methods.