fix coverage of isolated tests#1314
Merged
bdraco merged 13 commits intoaio-libs:masterfrom Apr 13, 2026
Merged
Conversation
Vizonex
added a commit
to Vizonex/multidict
that referenced
this pull request
Apr 3, 2026
psf-chronographer
bot
added
the
bot:chronographer:provided
…tidict into coverage-of-isolated
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 97.60% 99.85% +2.24%
==========================================
Files 26 26
Lines 3513 3513
Branches 253 253
==========================================
+ Hits 3429 3508 +79
+ Misses 77 3 -74
+ Partials 7 2 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
webknjaz
requested changes
Apr 3, 2026
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
webknjaz
previously requested changes
Apr 4, 2026
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
3 tasks
bdraco
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Dreamsorcerer has brought up with me a pretty interesting idea with me on matrix to help us fix code coverage with the isolated tests which I have now chosen to take his advice on.
This PR is meant to assist with fixing code coverage of isolated tests being added. This has been a recent problem with #1310 & #1311 as they fail to pass due to missing it's code coverage.
Are there changes in behavior for the user?
Maintainers working on multidict weather it's patching bugs or adding new features should have a less stressful time trying to put together bug scripts for the C Extension of multidict now if this PR passes through.
Related issue number
Checklist