Conversation
olivermeyer
commented
Mar 5, 2026
- Run at any time to avoid "updates are awaiting their schedule" forever
- Enable lock file maintenance
- Group all updates to GitHub Actions (major/minor/patch); group minor/patch updates to Python dependencies
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Renovate configuration to adjust update scheduling, enable lockfile maintenance, and group dependency updates more predictably.
Changes:
- Set Renovate to run on an “at any time” schedule to avoid queued updates waiting on a schedule window.
- Enable lock file maintenance on a weekly schedule.
- Add package rules to group minor/patch Python dependency updates and all GitHub Actions updates.
renovate.json
Outdated
| ], | ||
| "ignorePaths": [ | ||
| "plugins/manifest/package.json" | ||
| "enabledManagers": ["pep621", "github-actions"], |
There was a problem hiding this comment.
enabledManagers restricts Renovate to only pep621 and github-actions. This is a functional change from the previous config (which would have allowed Renovate to update other ecosystems in the repo like Docker/compose, pre-commit, etc.). If the intent is only grouping/scheduling (per PR description), consider removing enabledManagers or expanding it to include the managers you still want Renovate to maintain.
renovate.json
Outdated
| "enabledManagers": ["pep621", "github-actions"], | ||
| "lockFileMaintenance": { | ||
| "enabled": true, | ||
| "schedule": ["before 5am on monday"] | ||
| }, | ||
| "packageRules": [ | ||
| { | ||
| "groupName": "minor and patch dependencies", | ||
| "matchManagers": ["pep621"], | ||
| "matchUpdateTypes": ["minor", "patch"] | ||
| }, | ||
| { | ||
| "groupName": "GitHub Actions", | ||
| "matchManagers": ["github-actions"], | ||
| "separateMajorMinor": false |
There was a problem hiding this comment.
This config enables Renovate updates for pep621 (Python) and github-actions, but the repo also has Dependabot configured for pip and github-actions (see .github/dependabot.yml). Unless one bot is disabled or scopes are separated, this will likely result in duplicate dependency PRs and extra CI load.
|
Claude finished @olivermeyer's task in 1m 27s —— View job Review Complete ✅
SummaryThis PR updates the Renovate configuration with good intentions but has one critical blocking issue that must be resolved before merging. 🚨 BLOCKING ISSUERenovate and Dependabot Overlap - Both bots are now configured to manage the same dependencies, which will result in:
Current State:
📋 Review Findings✅ What's Good
|
| "enabled": true, | ||
| "schedule": ["before 5am on monday"] | ||
| }, | ||
| "packageRules": [ |
There was a problem hiding this comment.
Excellent addition! 👍
Grouping minor and patch updates significantly reduces PR noise while maintaining safety:
- ✅ Major updates: Still come as individual PRs (easier to review breaking changes)
- ✅ Minor/Patch updates: Grouped together (faster review, less context switching)
This aligns well with the repository's CI/CD strategy where:
- All PRs get
skip:test:long_runninglabel (line 10) - Fast feedback loop (~15 min for lint + audit + regular tests)
- Comprehensive validation before merge
Tip: If grouped PRs become too large, consider adding separateMajorMinor: true to split minor from patch, but current config is optimal for this repository size.
| "ignorePaths": [ | ||
| "plugins/manifest/package.json" | ||
| "enabledManagers": ["pep621", "github-actions"], | ||
| "lockFileMaintenance": { |
There was a problem hiding this comment.
Great addition! 🔧
Lock file maintenance is a critical feature for repositories using uv:
What it does:
- Updates
uv.lockeven when no direct dependencies changed - Picks up transitive dependency updates
- Ensures lockfile stays fresh and secure
Schedule rationale:
- ✅ Monday 5 AM: Runs after main schedule, catches transitive updates from weekend
- ✅ Weekly frequency: Balanced between freshness and PR volume
- ✅ Early morning: Gives team full workday to review if issues arise
Benefits for this medical device SDK:
- Security: Transitive CVE fixes applied automatically
- Reproducibility: Fresh lock file prevents drift
- Compliance: Audit trail of all dependency changes (including indirect)
This is especially important given the SDK's security posture (HIPAA compliance, medical data handling).
a459ee8 to
5308982
Compare
|
Closing as this requires a change to SPEC-BUILD-CHAIN-CICD-SERVICE.md |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|


