Fixes for low prio license compliance#416
Conversation
…er compatibility with pypi
|
Created license_report.md I used pip-licenses to generate the report and all dependencies are compatible with Apache-2.0 EXCEPT some cuda libraries and ts2vec:
This means that all current dependencies in leakpro is OK |
|
The NOTICE file contains a |
…and NOTICE, cleaner to just ref to NOTICE
fazelehh
left a comment
There was a problem hiding this comment.
-Some other comments:
pyproject.toml not visible in diff: The PR description lists it as a key change, but it wasn't present in the diff.
-Dev artifact files getting headers instead of being removed
[examples/gia/bn_research/main_copy.py]and [main_copy_copy.py] are leftover dev files. shouldnt they be deleted instead?
-Missing newline at the end of NOTICE and AGPL LICENSE files
Both NOTICE and examples/gia/coco_yolo_1_image/LICENSE end without a trailing newline (\ No newline at end of file). Minor POSIX non-compliance that can cause issues with some license-scanning tooling.
|
Created a issue for the copy files: #419 |
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
Related Pull Requests