Skip to content

Fixes for low prio license compliance#416

Open
TheColdIce wants to merge 18 commits intomainfrom
issue414
Open

Fixes for low prio license compliance#416
TheColdIce wants to merge 18 commits intomainfrom
issue414

Conversation

@TheColdIce
Copy link
Copy Markdown
Collaborator

@TheColdIce TheColdIce commented Apr 29, 2026

Description

Summary of changes

  • Updated pyproject.toml
  • Checked that all licenses of the dependencies are compatible with Apache-2.0
  • Added attributions to all flaticon images in NOTICE, README and on the wiki
  • Update mia_flow img
  • Talked to legal regarding purchasing third party tool for copied code audit and maintenance - I suggest we wait with implementing any solution before we know their decision
  • Updated NOTICE with HopSkipJumpDistance and BCJR decoder ref, also modified header of BCJR decoder
  • Added license for examples/ and examples/gia/coco_yolo_1_image/ - everything under examples/ is licensed under apache-2.0 if there is not a LICENSE file for the specific example.
  • Added headers to files in examples/

Resolved Issues

How Has This Been Tested?

Related Pull Requests

@TheColdIce
Copy link
Copy Markdown
Collaborator Author

Created license_report.md

I used pip-licenses to generate the report and all dependencies are compatible with Apache-2.0 EXCEPT some cuda libraries and ts2vec:

This means that all current dependencies in leakpro is OK

@TheColdIce
Copy link
Copy Markdown
Collaborator Author

The NOTICE file contains a Scientific Acknowledgments section. It is not strictly necessary that the section is up to date, but it is highly recommended. I think we should see if the third party tool can find scientific references before manually updating the NOTICE file.

Copy link
Copy Markdown
Collaborator

@fazelehh fazelehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Some other comments:
pyproject.toml not visible in diff: The PR description lists it as a key change, but it wasn't present in the diff.

-Dev artifact files getting headers instead of being removed
[examples/gia/bn_research/main_copy.py]and [main_copy_copy.py] are leftover dev files. shouldnt they be deleted instead?

-Missing newline at the end of NOTICE and AGPL LICENSE files
Both NOTICE and examples/gia/coco_yolo_1_image/LICENSE end without a trailing newline (\ No newline at end of file). Minor POSIX non-compliance that can cause issues with some license-scanning tooling.

Comment thread examples/mia/time_series_mia/utils/models/NBeats.py
Comment thread README.md Outdated
@TheColdIce TheColdIce requested a review from fazelehh May 5, 2026 08:37
@TheColdIce
Copy link
Copy Markdown
Collaborator Author

Created a issue for the copy files: #419

Comment thread NOTICE Outdated
Comment thread NOTICE
Comment thread resources/license_report_2026_05_04.md
@TheColdIce TheColdIce requested a review from fazelehh May 5, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix license compliance lower prio

2 participants